Commits on Jun 21, 2023

1. Move snapshot files to enumerated paths …

   MetricFlow has sets of query planning and dialect rendering tests
   that compare against snapshot files representing plans and SQL
   queries. For dialect-specific constructs, we rely on a dialect-
   specific snapshot file. For historical reasons, these were stored
   in a path location bound to the SqlClient class used in the tests.
   
   Now that we are moving to a model where we delegate this work to
   dbt adapters, we will be re-using the same SqlClient class for
   multiple dialects. More generally, we'd like to separate our
   warehouse client from our dialect operations. So this commit
   moves the relevant files to a path based on the target engine
   property of the SqlClient interface. Since our dialects currently
   map on to supported engines 1:1, we can do this for now, and
   eventually convert to dialect-only differentiation in the future.

   

   tlento committed Jun 21, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for d45f27e
   • Browse repository at this point

   Copy the full SHA

   d45f27e View commit details

   Browse the repository at this point in the history