Skip to content

Commit

Permalink
fix: temporarily disable google/cloud/storagetransfer on macOS
Browse files Browse the repository at this point in the history
See googleapis#8785 about a name clash on `UID_MAX` from `<sys/syslimits.h>`.
  • Loading branch information
devbww committed Apr 25, 2022
1 parent 2275fa7 commit 1c6c4e0
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 0 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,13 @@ noted, the APIs in these libraries are stable, and are ready for production use.
necessarily depends on these implementation details. We updated the
[mocking examples][storage-mocking-link] to guide you in changing any tests.

### [Storage Transfer Service](https://github.com/googleapis/google-cloud-cpp/blob/main/google/cloud/storagetransfer/README.md)

**BREAKING CHANGES**

The library has been disabled on macOS due to a protobuf naming clash. See
[#8785](https://github.com/googleapis/google-cloud-cpp/issues/8785) for details.

### New Libraries

We are introducing 2 new client libraries for GCP services. While we do not
Expand Down
5 changes: 5 additions & 0 deletions google/cloud/storagetransfer/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@ cc_library(
include = [HEADER_GLOB],
exclude = [MOCK_HEADER_GLOB],
),
# TODO(#8785): Enable on macOS and windows.
target_compatible_with = select({
"@platforms//os:macos": ["@platforms//:incompatible"],
"//conditions:default": [],
}),
visibility = ["//:__pkg__"],
deps = [
"//:common",
Expand Down
10 changes: 10 additions & 0 deletions google/cloud/storagetransfer/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,16 @@
# limitations under the License.
# ~~~

# TODO(8785): Enable on macOS.
if (APPLE)
message(
WARNING
"Cannot build google/cloud/storagetransfer on Apple platforms."
" More details at https://github.com/googleapis/google-cloud-cpp/issues/8785 ."
)
return()
endif ()

include(GoogleapisConfig)
set(DOXYGEN_PROJECT_NAME "Storage Transfer API C++ Client")
set(DOXYGEN_PROJECT_BRIEF "A C++ Client Library for the Storage Transfer API")
Expand Down

0 comments on commit 1c6c4e0

Please sign in to comment.