Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable google/cloud/storagetransfer on macOS #8785

Closed
devbww opened this issue Apr 25, 2022 · 3 comments · Fixed by #11672
Closed

Enable google/cloud/storagetransfer on macOS #8785

devbww opened this issue Apr 25, 2022 · 3 comments · Fixed by #11672
Labels
api: storagetransfer Issues related to the Storage Transfer Service API. external This issue is blocked on a bug with the actual product. type: cleanup An internal cleanup or hygiene concern.
Milestone
All GCP Services ...

Comments

@devbww
Copy link
Contributor

devbww commented Apr 25, 2022 •
edited
Loading

We cannot compile google/cloud/storagetransfer with the latest googleapis (current as-of 2022-04-25) because the protos define a UID enum, which generates a UID_MAX identifier, which is a macro on macOS:

In file included from bazel-out/darwin-fastbuild/bin/external/com_google_googleapis/google/storagetransfer/v1/transfer.pb.h:39:
bazel-out/darwin-fastbuild/bin/external/com_google_googleapis/google/storagetransfer/v1/transfer_types.pb.h:3485:24: error: expected member name or ';' after declaration specifiers
  static constexpr UID UID_MAX =
  ~~~~~~~~~~~~~~~~~~~~ ^
/Applications/Xcode_12.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/usr/include/sys/syslimits.h:86:28: note: expanded from macro 'UID_MAX'
#define UID_MAX            2147483647U  /* max value for a uid_t (2^31-2) */
                           ^
@devbww devbww added type: cleanup An internal cleanup or hygiene concern. external This issue is blocked on a bug with the actual product. api: storagetransfer Issues related to the Storage Transfer Service API. labels Apr 25, 2022
devbww added a commit to devbww/google-cloud-cpp that referenced this issue Apr 25, 2022
@devbww
fix: temporarily disable google/cloud/storagetransfer on macOS
1c6c4e0 
See googleapis#8785 about a name clash on `UID_MAX` from `<sys/syslimits.h>`.
@devbww devbww mentioned this issue Apr 25, 2022
Merged
devbww added a commit that referenced this issue Apr 25, 2022
@devbww
fix!: temporarily disable google/cloud/storagetransfer on macOS (#8789)
cbde9c1 
See #8785 about a name clash on `UID_MAX` from `<sys/syslimits.h>`.
devbww added a commit to devbww/google-cloud-cpp that referenced this issue May 29, 2022
@devbww
fix: re-enable google/cloud/storagetransfer on macOS
5de5f88 
Reverse googleapis#8789 now that googleapis#9092 has imported a new protobuf release
that avoids the macOS `UID_MAX` issue.

Closes googleapis#8785.
@devbww devbww mentioned this issue May 29, 2022
Closed
@devbww
Copy link
Contributor Author

devbww commented May 29, 2022

Sigh. The same thing happens for GID_MAX:

bazel-out/darwin-fastbuild/bin/external/com_google_googleapis/google/storagetransfer/v1/transfer_types.pb.h:3520:24: error: expected member name or ';' after declaration specifiers
  static constexpr GID GID_MAX =
  ~~~~~~~~~~~~~~~~~~~~ ^
/Applications/Xcode_12.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/usr/include/sys/syslimits.h:78:28: note: expanded from macro 'GID_MAX'
#define GID_MAX            2147483647U  /* max value for a gid_t (2^31-2) */
                           ^

devbww added a commit to devbww/google-cloud-cpp that referenced this issue Jun 28, 2022
@devbww
fix: re-enable google/cloud/storagetransfer on macOS
c028278 
Reverse googleapis#8789 now that googleapis#9361 has imported a new protobuf release
that avoids the macOS UID_MAX/GID_MAX issue.

Closes googleapis#8785.
@devbww devbww mentioned this issue Jun 28, 2022
Closed
devbww added a commit to devbww/google-cloud-cpp that referenced this issue Jun 28, 2022
@devbww
fix: re-enable google/cloud/storagetransfer on macOS
b155d18 
Reverse googleapis#8789 now that googleapis#9361 has imported a new protobuf release
that avoids the macOS UID_MAX/GID_MAX issue.

Closes googleapis#8785.
devbww added a commit to devbww/google-cloud-cpp that referenced this issue Jun 28, 2022
@devbww
fix: re-enable google/cloud/storagetransfer on macOS
88f81fa 
Reverse googleapis#8789 now that googleapis#9361 has imported a new protobuf release
that avoids the macOS UID_MAX/GID_MAX issue.

Closes googleapis#8785.
devbww added a commit to devbww/google-cloud-cpp that referenced this issue Jun 28, 2022
@devbww
fix: re-enable google/cloud/storagetransfer on macOS
b5d883d 
Reverse googleapis#8789 now that googleapis#9361 has imported a new protobuf release
that avoids the macOS UID_MAX/GID_MAX issue.

Closes googleapis#8785.
@coryan
Copy link
Contributor

coryan commented Nov 9, 2022

Still waiting for the protobuf updates

@coryan
Copy link
Contributor

coryan commented Apr 19, 2023

We need to check after Protobuf v23 and the corresponding gRPC.

devbww added a commit to devbww/google-cloud-cpp that referenced this issue May 19, 2023
@devbww
cleanup: re-enable google/cloud/storagetransfer on macOS
29da628 
Reverse googleapis#8789 now that we have a new protobuf release that avoids
the macOS `UID_MAX`/`GID_MAX` issue.

Fixes googleapis#8785.
@devbww devbww mentioned this issue May 19, 2023
Merged
devbww added a commit that referenced this issue May 20, 2023
@devbww
cleanup: re-enable google/cloud/storagetransfer on macOS (#11672)
1af7bba 
Reverse #8789 now that we have a new protobuf release that avoids
the macOS `UID_MAX`/`GID_MAX` issue.

Fixes #8785.
@coryan coryan mentioned this issue May 24, 2023
Closed
@autoantwort autoantwort mentioned this issue Jun 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: storagetransfer Issues related to the Storage Transfer Service API. external This issue is blocked on a bug with the actual product. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
All GCP Services have a GA library: M2
2 participants
@coryan @devbww