Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: re-enable google/cloud/storagetransfer on macOS #11672

Merged
merged 1 commit into from
May 20, 2023

Conversation

devbww
Copy link
Contributor

@devbww devbww commented May 19, 2023

Reverse #8789 now that we have a new protobuf release that avoids the macOS UID_MAX/GID_MAX issue.

Fixes #8785.


This change is Reviewable

Reverse googleapis#8789 now that we have a new protobuf release that avoids
the macOS `UID_MAX`/`GID_MAX` issue.

Fixes googleapis#8785.
@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (5b5317d) 82.99% compared to head (29da628) 82.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11672      +/-   ##
==========================================
- Coverage   82.99%   82.99%   -0.01%     
==========================================
  Files        1778     1778              
  Lines      162161   162161              
==========================================
- Hits       134589   134588       -1     
- Misses      27572    27573       +1     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@devbww devbww marked this pull request as ready for review May 20, 2023 02:24
@devbww devbww requested a review from a team as a code owner May 20, 2023 02:24
@devbww devbww merged commit 1af7bba into googleapis:main May 20, 2023
@devbww devbww deleted the enable-storagetransfer branch May 20, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable google/cloud/storagetransfer on macOS
2 participants