fix: re-enable google/cloud/storagetransfer on macOS #9102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverse googleapis#8789 now that googleapis#9092 has imported a new protobuf release that avoids the macOS `UID_MAX` issue. Closes googleapis#8785.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #9102 +/- ##
=======================================
Coverage 94.39% 94.39%
=======================================
Files 1430 1430
Lines 127761 127761
=======================================
+ Hits 120594 120599 +5
+ Misses 7167 7162 -5
Continue to review full report at Codecov.
|
devbww
commented
May 29, 2022
There was a problem hiding this comment.
Ergh!
bazel-out/darwin-fastbuild/bin/external/com_google_googleapis/google/storagetransfer/v1/transfer_types.pb.h:3520:24: error: expected member name or ';' after declaration specifiers
static constexpr GID GID_MAX =
~~~~~~~~~~~~~~~~~~~~ ^
/Applications/Xcode_12.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/usr/include/sys/syslimits.h:78:28: note: expanded from macro 'GID_MAX'
#define GID_MAX 2147483647U /* max value for a gid_t (2^31-2) */
^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverse #8789 now that #9092 has imported a new protobuf release
that avoids the macOS
UID_MAXissue.Closes #8785.
This change is