Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: re-enable google/cloud/storagetransfer on macOS #9102

Closed
wants to merge 1 commit into from
+0 −15
Closed

fix: re-enable google/cloud/storagetransfer on macOS #9102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions google/cloud/storagetransfer/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,6 @@ cc_library(
include = [HEADER_GLOB],
exclude = [MOCK_HEADER_GLOB],
),
# TODO(#8785): Enable on macOS.
target_compatible_with = select({
"@platforms//os:macos": ["@platforms//:incompatible"],
"//conditions:default": [],
}),
visibility = ["//:__pkg__"],
deps = [
"//:common",
Expand Down
10 changes: 0 additions & 10 deletions google/cloud/storagetransfer/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,6 @@
# limitations under the License.
# ~~~

# TODO(#8785): Enable on macOS.
if (APPLE)
message(
WARNING
"Cannot build google/cloud/storagetransfer on Apple platforms."
" More details at https://github.com/googleapis/google-cloud-cpp/issues/8785 ."
)
return()
endif ()

include(GoogleapisConfig)
set(DOXYGEN_PROJECT_NAME "Storage Transfer API C++ Client")
set(DOXYGEN_PROJECT_BRIEF "A C++ Client Library for the Storage Transfer API")
Expand Down