Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ATA HD initialization on Beige G3 when booting 9.2 #114

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Fix ATA HD initialization on Beige G3 when booting 9.2 #114

merged 1 commit into from
Aug 23, 2024

Conversation

mihaip
Copy link
Contributor

@mihaip mihaip commented Aug 23, 2024

1f2256e and 7ee8b9b were referencing a multiple_sector_count field, but it was never set. This was resulting in an error being returned (READ MULTIPLE with SET MULTIPLE==0). We actually should use sec_per_block, which bd16b7c introduced.

@mihaip
Fix ATA HD initialization on Beige G3 when booting 9.2
8d95aa5 
1f2256e/7ee8b9b2 were referencing a multiple_sector_count field,
but it was never set. This was resulting in an error being returned
(`READ MULTIPLE with SET MULTIPLE==0`).` We actually should use
`sec_per_block``, which bd16b7c introduced.
@maximumspatium maximumspatium merged commit 47237ff into dingusdev:master Aug 23, 2024
5 checks passed
@roytam1
Copy link
Contributor

roytam1 commented Aug 23, 2024 •
edited
Loading

... but can we confirm that multiple_enabled should be true by default?

@mihaip mihaip deleted the upstream-atahd-fix branch August 26, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mihaip @roytam1 @maximumspatium