Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(website): resolve linkTags in meta description #10088

Merged
merged 6 commits into from
Feb 3, 2024
Merged

fix(website): resolve linkTags in meta description #10088

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4785a64
fix(website): resolve linkTags in summaries
brynpttrsn Jan 14, 2024
877f6fe
fix: case body as block
brynpttrsn Jan 14, 2024
8ec8de5
fix: add discord-api-types support
brynpttrsn Jan 17, 2024
d3e62cb
fix: remove urlDestination when undefined
brynpttrsn Jan 17, 2024
1c05608
fix: breaks to if/else
brynpttrsn Jan 18, 2024
886d00c
Merge branch 'main' into fix/description-links-undefined
kodiakhq[bot] Feb 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/scripts/src/generateIndex.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,18 @@ export function tryResolveSummaryText(item: ApiDeclaredItem): string | null {
retVal += (node as DocPlainText).text;
break;
case DocNodeKind.LinkTag:
retVal += (node as DocLinkTag).urlDestination;
{
const { codeDestination, urlDestination, linkText } = node as DocLinkTag;
if (codeDestination) {
const declarationReference = item.getAssociatedModel()?.resolveDeclarationReference(codeDestination, item);
const foundItem = declarationReference?.resolvedApiItem;
retVal += urlDestination ?? linkText ?? foundItem?.displayName;
break;
brynpttrsn marked this conversation as resolved.
Show resolved Hide resolved
}

retVal += linkText ?? urlDestination;
}

break;
brynpttrsn marked this conversation as resolved.
Show resolved Hide resolved
case DocNodeKind.Section:
case DocNodeKind.Paragraph: {
Expand Down