Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mariadb docs update #2080

Merged
merged 9 commits into from
Nov 25, 2021
Merged

Conversation

grooverdan
Copy link
Contributor

@grooverdan grooverdan commented Nov 16, 2021

A collection of updates and new content.

Copy link
Member

@yosifkit yosifkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments and suggestions

mariadb/content.md Outdated Show resolved Hide resolved
mariadb/content.md Outdated Show resolved Hide resolved
mariadb/content.md Outdated Show resolved Hide resolved
mariadb/content.md Outdated Show resolved Hide resolved
grooverdan and others added 6 commits November 19, 2021 17:44
As mentioned in #2708 docs documenting how to change the port,
particular for host networking was requested.

The example in "configuration without a cnf file section" was
already the default anyway (utf8), so this was just replaced.

Using MARIADB_ROOT_PASSWORD in the example to move away from
MySQL naming (still supported however).

Closes: docker-library#2078
Co-authored-by: yosifkit <yosifkit@gmail.com>
Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seems fine -- just a few minor review comments (for your consideration) and one markdown formatting bug 👀

I don't feel strongly about any of these though, and am happy to merge as-is if you'd rather. 👍

mariadb/content.md Outdated Show resolved Hide resolved
mariadb/content.md Outdated Show resolved Hide resolved
mariadb/content.md Outdated Show resolved Hide resolved
grooverdan and others added 3 commits November 25, 2021 12:13
Formatting on INSTALL SONAME

Co-authored-by: Tianon Gravi <admwiggin@gmail.com>
Compressed backup simplier

Co-authored-by: Tianon Gravi <admwiggin@gmail.com>
better use of apt-get arguments

Co-authored-by: Tianon Gravi <admwiggin@gmail.com>
@grooverdan
Copy link
Contributor Author

Nice improvements, thanks. Ready when you/ci is.

@tianon tianon merged commit 37666d4 into docker-library:master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants