Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node.js 4.0.0 and switch to nodejs GitHub org #1036

Merged
merged 1 commit into from
Sep 9, 2015
Merged

Add Node.js 4.0.0 and switch to nodejs GitHub org #1036

merged 1 commit into from
Sep 9, 2015

Conversation

chorrell
Copy link
Contributor

@chorrell chorrell commented Sep 9, 2015

Node.js 4.0.0!

Test build looks good!

fixes #1035

@ricardohbin
Copy link

Yeah! +1

@knksmith57
Copy link

boom! +1

@yosifkit
Copy link
Member

yosifkit commented Sep 9, 2015

Changeset: nodejs/docker-node@d798690...c2a8075

LGTM, Build test of #1036; c9961ea (node):

$ url="https://raw.githubusercontent.com/docker-library/official-images/c9961ea05f457dece08796842168e8c33224a773/library/node"
$ bashbrew build "$url"
Cloning node (git://github.com/nodejs/docker-node) ...
Processing node:0.10.40 ...
Processing node:0.10 ...
Processing node:0.10.40-onbuild ...
Processing node:0.10-onbuild ...
Processing node:0.10.40-slim ...
Processing node:0.10-slim ...
Processing node:0.10.40-wheezy ...
Processing node:0.10-wheezy ...
Processing node:0.12.7 ...
Processing node:0.12 ...
Processing node:0.12.7-onbuild ...
Processing node:0.12-onbuild ...
Processing node:0.12.7-slim ...
Processing node:0.12-slim ...
Processing node:0.12.7-wheezy ...
Processing node:0.12-wheezy ...
Processing node:4.0.0 ...
Processing node:4.0 ...
Processing node:0 ...
Processing node:latest ...
Processing node:4.0.0-onbuild ...
Processing node:4.0-onbuild ...
Processing node:0-onbuild ...
Processing node:onbuild ...
Processing node:4.0.0-slim ...
Processing node:4.0-slim ...
Processing node:0-slim ...
Processing node:slim ...
Processing node:4.0.0-wheezy ...
Processing node:4.0-wheezy ...
Processing node:0-wheezy ...
Processing node:wheezy ...
$ bashbrew list --uniq "$url" | xargs test/run.sh
testing node:0.10.40
    'utc' [1/4]...passed
    'cve-2014--shellshock' [2/4]...passed
    'no-hard-coded-passwords' [3/4]...passed
    'override-cmd' [4/4]...passed
testing node:0.10.40-onbuild
    'utc' [1/4]...passed
    'cve-2014--shellshock' [2/4]...passed
    'no-hard-coded-passwords' [3/4]...passed
    'override-cmd' [4/4]...passed
testing node:0.10.40-slim
    'utc' [1/4]...passed
    'cve-2014--shellshock' [2/4]...passed
    'no-hard-coded-passwords' [3/4]...passed
    'override-cmd' [4/4]...passed
testing node:0.10.40-wheezy
    'utc' [1/4]...passed
    'cve-2014--shellshock' [2/4]...passed
    'no-hard-coded-passwords' [3/4]...passed
    'override-cmd' [4/4]...passed
testing node:0.12.7
    'utc' [1/4]...passed
    'cve-2014--shellshock' [2/4]...passed
    'no-hard-coded-passwords' [3/4]...passed
    'override-cmd' [4/4]...passed
testing node:0.12.7-onbuild
    'utc' [1/4]...passed
    'cve-2014--shellshock' [2/4]...passed
    'no-hard-coded-passwords' [3/4]...passed
    'override-cmd' [4/4]...passed
testing node:0.12.7-slim
    'utc' [1/4]...passed
    'cve-2014--shellshock' [2/4]...passed
    'no-hard-coded-passwords' [3/4]...passed
    'override-cmd' [4/4]...passed
testing node:0.12.7-wheezy
    'utc' [1/4]...passed
    'cve-2014--shellshock' [2/4]...passed
    'no-hard-coded-passwords' [3/4]...passed
    'override-cmd' [4/4]...passed
testing node:4.0.0
    'utc' [1/4]...passed
    'cve-2014--shellshock' [2/4]...passed
    'no-hard-coded-passwords' [3/4]...passed
    'override-cmd' [4/4]...passed
testing node:4.0.0-onbuild
    'utc' [1/4]...passed
    'cve-2014--shellshock' [2/4]...passed
    'no-hard-coded-passwords' [3/4]...passed
    'override-cmd' [4/4]...passed
testing node:4.0.0-slim
    'utc' [1/4]...passed
    'cve-2014--shellshock' [2/4]...passed
    'no-hard-coded-passwords' [3/4]...passed
    'override-cmd' [4/4]...passed
testing node:4.0.0-wheezy
    'utc' [1/4]...passed
    'cve-2014--shellshock' [2/4]...passed
    'no-hard-coded-passwords' [3/4]...passed
    'override-cmd' [4/4]...passed

@Zolmeister
Copy link

+1

@tianon
Copy link
Member

tianon commented Sep 9, 2015

LGTM

tianon added a commit that referenced this pull request Sep 9, 2015
Add Node.js 4.0.0 and switch to nodejs GitHub org
@tianon tianon merged commit f742d4b into docker-library:master Sep 9, 2015
@chorrell chorrell deleted the node-4.0.0 branch April 6, 2016 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update node to 4.0.0
7 participants