Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 4.0.0 #42

Merged
merged 3 commits into from
Sep 9, 2015
Merged

Node 4.0.0 #42

merged 3 commits into from
Sep 9, 2015

Conversation

chorrell
Copy link
Contributor

@chorrell chorrell commented Sep 8, 2015

This adds Node.js v4.0.0 and sets it as the "latest" image.

Things to note:

  • The slim variant is based on iojs version of slim which is based off buildpack-deps:jessie-curl. This seemed a cleaner way to go rather than the fancy footwork approach of install/uninstalling curl and ca-certificates that was done in the slim variants of 0.10 and 0.12.
  • I'm including a wheezy variant similar to the Node.js 0.10 and 0.12 to keep things consistent.
  • generate-stackbrew-library.sh has been updated to set "latest" to 4.0
  • Update stackbrew for nodejs org change #41 will need to be merged first to avoid conflicts

Test build via test-build.sh passes :)

Closes #39

cc @nodejs/docker

@chorrell chorrell mentioned this pull request Sep 8, 2015
@Zolmeister
Copy link

+1

2 similar comments
@knksmith57
Copy link
Contributor

+1

@thiago
Copy link

thiago commented Sep 8, 2015

+1

@rfink
Copy link

rfink commented Sep 8, 2015

+1

@hmalphettes
Copy link
Member

+1
#41 is merged so nothing is missing now.

@karlbright
Copy link

👍

@hmalphettes
Copy link
Member

@chorrell what else do we need to do?

I am happy to click the buttons and make a PR to fix docker-library/official-images#1035 if nothing is missing.

@chorrell
Copy link
Contributor Author

chorrell commented Sep 9, 2015

@hmalphettes We just need to merge this and then submit a PR for https://github.com/docker-library/official-images.

If you're cool with that then click away!

The PR to official-images will also land the org switch as well as introducing 4.0.0

chorrell added a commit that referenced this pull request Sep 9, 2015
@chorrell chorrell merged commit da293e6 into nodejs:master Sep 9, 2015
@andreyvital
Copy link

@chorrell is it already published to registry?

@karlbright
Copy link

👏 Great job @chorrell

@karlbright
Copy link

@CentaurWarchief AFAIK the PR still needs to be submitted and merged for https://github.com/docker-library/official-images.

@andreyvital
Copy link

@karlbright
Copy link

@CentaurWarchief Ah thanks, missed that merge completely. 👍

@chorrell
Copy link
Contributor Author

chorrell commented Sep 9, 2015

We should be good now, just waiting on docker-library/official-images#1036 to land.

@hmalphettes we should be good now :)

@andreyvital
Copy link

Cool. Waiting for it.

🍻

@techniq
Copy link

techniq commented Sep 9, 2015

+1

@retrohacker
Copy link
Contributor

🎉 thanks @chorrell !!! 😄

@chorrell chorrell deleted the node-4.0.0 branch April 6, 2016 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants