Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new extension #4177

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Add new extension #4177

merged 1 commit into from
Dec 7, 2022

Conversation

ErikEJ
Copy link
Contributor

@ErikEJ ErikEJ commented Dec 7, 2022

No description provided.

Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ErikEJ.

Unless I'm mistaken the plugin takes care of the storage part, but doesn't provide any query translations for methods/members on DateOnly/TimeOnly - any plans to work on these too?

Of course, once the SqlClient LTS version is available, I intend to do built-in support in the SQL Server provider - including the translations (you can copy them at that point if you want).

@roji roji merged commit 8837358 into dotnet:main Dec 7, 2022
@ErikEJ
Copy link
Contributor Author

ErikEJ commented Dec 7, 2022

but doesn't provide any query translations for methods/members on DateOnly/TimeOnly

Hmm... Never thought of that, I have created ErikEJ/EFCore.SqlServer.DateOnlyTimeOnly#1 and will investigate

@roji
Copy link
Member

roji commented Dec 7, 2022

You can check out dotnet/efcore#24989 for the translations (and tests!) done for SQLite, I recommend looking at the PG provider too, it should have more extensive query translations.

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Dec 7, 2022

Thanks I will do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants