Implement DateOnly/TimeOnly support for Sqlite #24989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
commented
May 27, 2021
bricelam
approved these changes
May 27, 2021
src/EFCore.Sqlite.Core/Query/Internal/SqliteDateTimeAddTranslator.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Sqlite.Core/Query/Internal/SqliteDateTimeMemberTranslator.cs
Outdated
Show resolved
Hide resolved
roji
commented
May 28, 2021
|
@bricelam made all the changes, can you take a final quick look? |
roji
force-pushed
the
DateTimeOnly
branch
3 times, most recently
from
14f66e9
to
a5f75b1
Compare
|
Why does the build hate me so much |
smitpatel
reviewed
May 28, 2021
smitpatel
reviewed
May 28, 2021
test/EFCore.SqlServer.FunctionalTests/Query/GearsOfWarQuerySqlServerFixture.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
May 28, 2021
test/EFCore.SqlServer.FunctionalTests/Query/GearsOfWarQuerySqlServerTest.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Jun 1, 2021
test/EFCore.SqlServer.FunctionalTests/Query/TPTGearsOfWarQuerySqlServerTest.cs
Outdated
Show resolved
Hide resolved
bricelam
suggested changes
Jun 1, 2021
src/EFCore.Sqlite.Core/Query/Internal/SqliteDateOnlyMemberTranslator.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Jun 3, 2021
src/EFCore.Sqlite.Core/Query/Internal/SqliteDateOnlyMemberTranslator.cs
Outdated
Show resolved
Hide resolved
roji
force-pushed
the
DateTimeOnly
branch
3 times, most recently
from
139f72f
to
9dfa171
Compare
|
@bricelam (@smitpatel) have squashed and rebased this for net6.0, and cleaned up. In case you want to do a final review. |
bricelam
suggested changes
Jun 10, 2021
bricelam
approved these changes
Jun 15, 2021
|
Thanks @bricelam |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24506
Note: this doesn't add translations for TimeOnly, since none exist for TimeSpan at the moment (and some Sqlite magic needs to be done). Both can be done together as part of #18844.