Fix bug in ActiveIssueDiscoverer with condition member names (#5744)

In #5376 the logic was copied from the ConditionalFactDiscoverer but this is wrong. For ActiveIssue we want to _skip_ the test if the condition is true, rather than the other way round.
dotnet · Jul 3, 2020 · 46fe554 · 46fe554
1 parent 5548f58
commit 46fe554
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/Microsoft.DotNet.XUnitExtensions/src/Discoverers/ActiveIssueDiscoverer.cs b/src/Microsoft.DotNet.XUnitExtensions/src/Discoverers/ActiveIssueDiscoverer.cs
@@ -61,11 +61,11 @@ public IEnumerable<KeyValuePair<string, string>> GetTraits(IAttributeInfo traitA
 
             if (calleeType != null && conditionMemberNames != null)
             {
-                if (!DiscovererHelpers.Evaluate(calleeType, conditionMemberNames))
+                if (DiscovererHelpers.Evaluate(calleeType, conditionMemberNames))
                 {
                     yield return new KeyValuePair<string, string>(XunitConstants.Category, XunitConstants.Failing);
                 }
-            }        
+            }
             else if (DiscovererHelpers.TestPlatformApplies(platforms) &&
                 DiscovererHelpers.TestRuntimeApplies(runtimes) &&
                 DiscovererHelpers.TestFrameworkApplies(frameworks))