Fix bug in ActiveIssueDiscoverer with condition member names #5744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In dotnet#5376 the logic was copied from the ConditionalFactDiscoverer but this is wrong. For ActiveIssue we want to _skip_ the test if the condition is true, rather than the other way round.
ViktorHofer
approved these changes
Jul 3, 2020
akoeplinger
added a commit
to akoeplinger/runtime
that referenced
this pull request
Jul 3, 2020
The property only checked for the `MONO_ENV_OPTIONS=--interpreter` env var which isn't set on WebAssembly. This needed an arcade fix to correct an inverted condition in the ActiveIssue discoverer: dotnet/arcade#5744
akoeplinger
added a commit
to dotnet/runtime
that referenced
this pull request
Jul 3, 2020
The property only checked for the `MONO_ENV_OPTIONS=--interpreter` env var which isn't set on WebAssembly. This needed an arcade fix to correct an inverted condition in the ActiveIssue discoverer: dotnet/arcade#5744
ViktorHofer
pushed a commit
to dotnet/winforms
that referenced
this pull request
Dec 5, 2022
…time#38768) The property only checked for the `MONO_ENV_OPTIONS=--interpreter` env var which isn't set on WebAssembly. This needed an arcade fix to correct an inverted condition in the ActiveIssue discoverer: dotnet/arcade#5744 Commit migrated from dotnet/runtime@4aea0a1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5376 the logic was copied from the ConditionalFactDiscoverer but this is wrong.
For ActiveIssue we want to skip the test if the condition is true, rather than the other way round.