[WinForms] API validate input parameters and throw ANE

[RussKie]

Selected API validate input parameters and throw ArgumentNullException.

Selected API now validate input parameters and throw ArgumentNullException where previously a NullReferenceException could be thrown, if APIs were invoked with null input arguments.
Throwing ArgumentException is inline with the behaviours in .NET Runtime, and provides developers with a better debug experience clearly communicating which argument caused the exception.

Old behavior

The listed API would throw NullReferenceException if invoked with null input arguments.

New behavior

The listed API would throw ArgumentNullException if invoked with null input arguments.

Reason for change

Throwing ArgumentNullException is inline with the behaviours in .NET Runtime, and provides developers with a better debug experience clearly communicating which argument caused the exception.

Recommended action

• Review and, if necessary, update the code to prevent passing null input arguments in the listed API.
• If the code is handling NullReferenceException replace (or supplement) it with handling ArgumentNullException.

Category

• Windows Forms

Version introduced: .NET 5.0 Preview 1

Affected APIs

• Control.ControlCollection
  • Control.ControlCollection(Control) Constructor, parameter owner
• TabControl
  • GetToolTipText(Object), parameter item
• TableLayoutControlCollection
  • TableLayoutControlCollection(TableLayoutPanel) Constructor, parameter container
• ToolStripRenderer
  • OnRenderArrow(ToolStripArrowRenderEventArgs), parameter e
  • OnRenderItemImage(ToolStripItemImageRenderEventArgs), parameter e
  • OnRenderItemCheck(ToolStripItemImageRenderEventArgs), parameter e
  • OnRenderItemText(ToolStripItemTextRenderEventArgs), parameter e
  • OnRenderStatusStripSizingGrip(ToolStripRenderEventArgs), parameter e

Version introduced: .NET 5.0 Preview 2

Affected APIs

• DataGridViewComboBoxEditingControl
  • ApplyCellStyleToEditingControl(DataGridViewCellStyle), parameter dataGridViewCellStyle
• RichTextBox
  • LoadFile(Stream, RichTextBoxStreamType), parameter data

Version introduced: .NET 5.0 Preview 5

Affected APIs

• ListViewGroup
  • ISerializable.GetObjectData(SerializationInfo, StreamingContext), parameter info
• VisualStyleRenderer
  • VisualStyleRenderer(String, Int32, Int32), parameter className
• ListBox.IntegerCollection
  • ListBox.IntegerCollection(ListBox) Constructor, parameter owner
  • ListBox.IntegerCollection.CopyTo(Array, int), parameter destination

Version introduced: .NET 5.0 Preview 6

Affected APIs

• ListBox.ObjectCollection
  • ListBox.ObjectCollection(ListBox) Constructor, parameter owner
  • ListBox.ObjectCollection(ListBox, Object[]) Constructor, parameter owner
  • ListBox.ObjectCollection(ListBox, Object[]) Constructor, parameter value
  • ListBox.ObjectCollection(ListBox, ListBox+ObjectCollection) Constructor, parameter owner
  • ListBox.ObjectCollection(ListBox, ListBox+ObjectCollection) Constructor, parameter value
  • ListBox.ObjectCollection.AddRange(Object[]), parameter value
  • ListBox.ObjectCollection.AddRange(ListBox+ObjectCollection), parameter value
  • ListBox.ObjectCollection.CopyTo(Object[], Int32), parameter destination
  • ListBox.ObjectCollection.ICollection.CopyTo(Array, Int32), parameter destination

Version introduced: .NET 5.0 Preview 7

Affected APIs

• ListView.SelectedIndexCollection
  • ListView.SelectedIndexCollection(ListView) Constructor, parameter owner

Version introduced: .NET 5.0 Preview 8

Affected APIs

• TreeNodeCollection
  • TreeNodeCollection.Find(String, Boolean) Method, parameter key is null or empty.

Version introduced: .NET 5.0 RC1

Affected APIs

• ListViewItemCollection
  • ListViewItemCollection.Find(String, Boolean) Method, parameter key is null or empty.
• ScrollableControl
  • ScrollableControl.OnPaintBackground(PaintEventArgs) Method, parameter e is null.

---

Issue metadata

• Issue type: breaking-change

[gewarren]

@RussKie Shoot! I think the checklist will be easier since you don't have to edit the markdown.

[gewarren]

No, I'll reopen this one.

[RussKie]

I'll have new ones opened for 6.0 😉
Thank you for your help.