Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DataGridViewTextBoxEditingControl tests and fix bugs #2983

Merged
merged 1 commit into from
Mar 21, 2020
Merged

Add DataGridViewTextBoxEditingControl tests and fix bugs #2983

merged 1 commit into from
Mar 21, 2020

Conversation

hughbe
Copy link
Contributor

@hughbe hughbe commented Mar 17, 2020 •
edited by ghost
Loading

Proposed Changes

  • Add DataGridViewTextBoxEditingControl tests and fix bugs

Bugs Fixes

  • Validate dataGridViewCellStyle in ApplyCellStyleToEditingControl: fixes NRE
  • Fix NRE in NotifyDataGridViewOfValueChange without EditingControlDataGridView
  • Fix NRE in ApplyCellStyleToEditingControl without EditingControlDataGridView
  • Don't force handle creation in OnGotFocus or OnHandleCreated
  • Fix NRE in OnMouseWheel without EditingControlDataGridView
Microsoft Reviewers: Open in CodeFlow

@hughbe hughbe requested a review from a team as a code owner March 17, 2020 17:08
@ghost ghost assigned hughbe Mar 17, 2020
RussKie
RussKie previously approved these changes Mar 18, 2020
View reviewed changes
@RussKie
Copy link
Member

RussKie commented Mar 18, 2020

Builds fails:

System\Windows\Forms\DataGridViewTextBoxEditingControlTests.cs(419,21): error CS0111: Type 'DataGridViewTextBoxEditingControlTests' already defines a member called 'DataGridViewTextBoxEditingDataGridViewTextBoxEditingControl_Text_Set_GetReturnsExpected' with the same parameter types [D:\a\1\s\src\System.Windows.Forms\tests\UnitTests\System.Windows.Forms.Tests.csproj]
##[error]System\Windows\Forms\DataGridViewTextBoxEditingControlTests.cs(419,21): error CS0111: Type 'DataGridViewTextBoxEditingControlTests' already defines a member called 'DataGridViewTextBoxEditingDataGridViewTextBoxEditingControl_Text_Set_GetReturnsExpected' with the same parameter types

@RussKie
Copy link
Member

RussKie commented Mar 18, 2020

Docs added dotnet/docs#17085

@RussKie RussKie added 📖 documentation: breaking A change in behavior that could be breaking for applications. Needs to be documented. test-enhancement Improvements of test source code labels Mar 18, 2020
@hughbe hughbe force-pushed the DataGridViewEditnigControl-tests branch 9 times, most recently from 404bf72 to c16c8c0 Compare March 20, 2020 19:54
@hughbe hughbe force-pushed the DataGridViewEditnigControl-tests branch from c16c8c0 to 262b684 Compare March 20, 2020 21:41
@codecov
Copy link

codecov bot commented Mar 21, 2020

Codecov Report

Merging #2983 into master will increase coverage by 0.19935%.
The diff coverage is 99.46809%.

@@                 Coverage Diff                 @@
##              master       #2983         +/-   ##
===================================================
+ Coverage   61.94595%   62.14530%   +0.19934%     
===================================================
  Files           1256        1257          +1     
  Lines         447545      449429       +1884     
  Branches       39209       39228         +19     
===================================================
+ Hits          277236      279299       +2063     
+ Misses        164844      164656        -188     
- Partials        5465        5474          +9
Flag Coverage Δ
#Debug 62.14530% <99.46809%> (+0.19934%) ⬆️
#production 33.33981% <95.65217%> (+0.08196%) ⬆️
#test 98.97337% <100.00000%> (+0.00011%) ⬆️

@RussKie RussKie merged commit 8138af1 into dotnet:master Mar 21, 2020
@ghost ghost added this to the 5.0 milestone Mar 21, 2020
@hughbe hughbe deleted the DataGridViewEditnigControl-tests branch March 21, 2020 08:45
M-Lipin pushed a commit to M-Lipin/winforms that referenced this pull request Mar 23, 2020
@hughbe
Add DataGridViewTextBoxEditingControl tests and fix bugs (dotnet#2983)
6f8cf65
@ghost ghost locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RussKie RussKie RussKie left review comments

Assignees

@hughbe hughbe

Labels
📖 documentation: breaking A change in behavior that could be breaking for applications. Needs to be documented. test-enhancement Improvements of test source code
Projects
None yet
Milestone
5.0 Previews 1-4
Development

Successfully merging this pull request may close these issues.
2 participants
@hughbe @RussKie