-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MsQuic on Ubuntu 18.04 #921
Conversation
@lbussell - It appears the Ubuntu builds are broken unrelated to these changes. |
I assume this is the same problem as #903 😢 |
Taking a look at the failure. |
I think this needs never node @lbussell.
|
Yeah, that was it, got it building locally so let's hope that's the only issue. |
The Raspbian may be different issue. I was trying to figure out of I can build arm32 on arm64.... and in mean time I'm refreshing my Raspberry so I can possibly build arm32 natively. |
|
OK, trying to fix that issue by adding |
I have access to arm64 build machine so I can try more if needed @lbussell. |
actually, Ubuntu 18.04 is EOL https://ubuntu.com/blog/ubuntu-18-04-eol-for-devices |
It'd be great to drop 18.04 - but don't we still need to keep this image buildable to support .NET 6 and 7? |
Actually, this 18.04 image isn't even being updated in this PR, the image exists in MCR already, it won't get any more security updates, so we should just delete it. If Raspbian 10 is blocking any other PRs we should consider a similar approach there. |
@wfurt, @CarnaViire, @ManickaP, would moving the failing runtime tests to 20.04/22.04 unblock your PR? |
So @wfurt, @CarnaViire, @ManickaP, this is building now, but I would still probably recommend moving the 8.0/main tests off 18.04 especially if we aren't supporting it for 8.0/9.0. These Dockerfiles should all be removed soon. |
@lbussell Debian 10 and Debian 11 Arm images are also failing -- I assume the same changes should be applied to them? I'll try to put up a PR with that. UPD: Opened #925 |
cc @wfurt @ManickaP @mthalman