Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Debian Arm32 build #925

Closed
wants to merge 3 commits into from
Closed

Fix Debian Arm32 build #925

wants to merge 3 commits into from

Conversation

CarnaViire
Copy link
Member

@CarnaViire CarnaViire commented Oct 19, 2023 •
edited
Loading

Port changes from Ubuntu Arm32 (#921) to Debian 10 and 11.

Contributes to #903

cc @wfurt @lbussell @mthalman

@CarnaViire CarnaViire mentioned this pull request Oct 19, 2023
Merged
wfurt
wfurt approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

should close #903 ???

@lbussell
Copy link
Contributor 

Rust 1.48.0 does not match extension requirement >=1.56.0

Fixing that isn't going to be pretty.

@wfurt
Copy link
Member

wfurt commented Oct 19, 2023 

Rust 1.48.0 does not match extension requirement >=1.56.0

Fixing that isn't going to be pretty.

do you want me to look @lbussell ? I have my ARM machine almost ready. Feel free to jump on it if you feel like.

@lbussell
Copy link
Contributor

I assume you would have to use rustup to get a newer rust on Debian. I hate this because

  1. We don't even need rust in the final image, this just adds complexity and size
  2. The installation method is just curl | bash. That isn't good from a secure supply chain perspective.

@lbussell lbussell mentioned this pull request Oct 25, 2023
Merged
@CarnaViire CarnaViire closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wfurt wfurt wfurt approved these changes

Assignees
No one assigned
Labels
area-infrastructure untriaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CarnaViire @lbussell @wfurt