[master] Update dependencies from dotnet/arcade #1678

dotnet-maestro · 2020-06-01T12:04:46Z

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

Subscription: 4aa0500b-5e23-4057-d462-08d76e1d3434
Build: 20200528.4
Date Produced: 5/28/2020 4:10 PM
Commit: 96c65ad967d2abbbd8e770ba752a6b64255ec669
Branch: refs/heads/master
Updates:
- Microsoft.DotNet.Arcade.Sdk: from 5.0.0-beta.20261.9 to 5.0.0-beta.20278.4
Updates to .NET SDKs:
- Updates sdk.version to 5.0.100-preview.6.20266.3
- Updates tools.dotnet to 5.0.100-preview.6.20266.3

…528.4 Microsoft.DotNet.Arcade.Sdk From Version 5.0.0-beta.20261.9 -> To Version 5.0.0-beta.20278.4

dotnet-maestro · 2020-06-01T12:08:26Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: ef6-ci
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
✔️ Standard Merge Policies Succeeded - No version downgrade detected.

BrennanConroy · 2020-06-02T00:15:33Z

@ajcvickers Can you find someone to look into this?

##[error]artifacts\obj\ef6\Release\net40\ef6.AssemblyInfo.cs(21,30): error CS0234: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'AssemblyMetadataAttribute' does not exist in the namespace 'System.Reflection' (are you missing an assembly reference?)

dotnet-maestro · 2020-06-02T00:20:05Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: ef6-ci
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
✔️ Standard Merge Policies Succeeded - No version downgrade detected.

ajcvickers · 2020-06-02T14:12:07Z

@smitpatel @bricelam Any ideas?

dotnet-maestro · 2020-06-02T14:16:24Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: ef6-ci
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
✔️ Standard Merge Policies Succeeded - No version downgrade detected.

smitpatel · 2020-06-02T16:57:24Z

I investigated a bit into this.

It is not intermittent error. It is legit compilation failure.
The same code works fine in master branch and this PR does not change any code apart from SDK. There are potentially breaking changes in this SDK.

Looking for AssemblyMetadataAttribute, it is being used in code as following

ef6/src/SharedAssemblyInfo.cs

Lines 9 to 29 in 0210404

    
           [assembly: AssemblyMetadata("Serviceable", "True")] 
        
           #if NET40 
        
           namespace System.Reflection 
        
           { 
        
               [AttributeUsage(AttributeTargets.Assembly, AllowMultiple = true, Inherited = false)] 
        
               internal sealed class AssemblyMetadataAttribute : Attribute 
        
               { 
        
                   public AssemblyMetadataAttribute(string key, string value) 
        
                   { 
        
                       Key = key; 
        
                       Value = value; 
        
                   } 
        
                   public string Key { get; set; } 
        
                   public string Value { get; set; } 
        
               } 
        
           } 
        
           #endif

The error only happens during net4.0 compilation but the same file already defines the attribute so I don't know why it is saying it is missing.

Perhaps someone from runtime/SDK team should check and figure out if the SDK has made breaking change and guide how to change our code according to it.

dotnet-maestro · 2020-06-02T16:57:36Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: ef6-ci
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
✔️ Standard Merge Policies Succeeded - No version downgrade detected.

halter73 · 2020-06-03T01:10:30Z

The error only happens during net4.0 compilation but the same file already defines the attribute so I don't know why it is saying it is missing.

I checked out this PR locally and looked at artifacts\obj\ef6\Release\net40\ef6.AssemblyInfo.cs. It's not the same things as SharedAssemblyInfo.cs. It's a file "Generated by the MSBuild WriteCodeFragment class."

So I then added <Compile Include="..\SharedAssemblyInfo.cs" /> to ef6.csproj. This fixed the build error. I'm not sure why this wasn't necessary before.

@smitpatel I opened #1680 to include SharedAssemblyInfo.cs in ef6.csrproj. Does this make sense?

dotnet-maestro · 2020-06-03T01:11:51Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: ef6-ci
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
✔️ Standard Merge Policies Succeeded - No version downgrade detected.

halter73 · 2020-06-03T18:04:57Z

@smitpatel It looks like we have a new issue. Can you or someone else take a look at what's causing the test failure?

DbContext_initialization_should_work_when_called_concurrently_from_multiple_threads_even_if_first_the_first_few_fail

Error message
Assert.IsType() Failure\r\nExpected: System.Data.Entity.Core.ProviderIncompatibleException\r\nActual: System.NullReferenceException

Stack trace
   at ProductivityApiTests.MultiThreadingTests.DbContext_initialization_should_work_when_called_concurrently_from_multiple_threads_even_if_first_the_first_few_fail() in /_/test/FunctionalTests/ProductivityApi/MultiThreadingTests.cs:line 125

dotnet-maestro · 2020-06-03T18:05:14Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: ef6-ci
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
✔️ Standard Merge Policies Succeeded - No version downgrade detected.

halter73 · 2020-06-03T18:10:51Z

It looks like this is just a flaky test, so I'll rerun. @ajcvickers Is there a test quarantine process for this repo?

smitpatel · 2020-06-03T18:11:22Z

@halter73 - Thanks Stephen for investigating earlier issue. I will look into the test failure.

dotnet-maestro · 2020-06-03T18:15:22Z

Auto-Merge Status

This pull request will be merged because the following merge policies have succeeded.

✔️ Standard Merge Policies Succeeded - Successful checks: ef6-ci
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
✔️ Standard Merge Policies Succeeded - No version downgrade detected.

Update dependencies from https://github.com/dotnet/arcade build 20200…

33163a5

…528.4 Microsoft.DotNet.Arcade.Sdk From Version 5.0.0-beta.20261.9 -> To Version 5.0.0-beta.20278.4

halter73 mentioned this pull request Jun 3, 2020

Fix dependency update PR #1680

Merged

halter73 mentioned this pull request Jun 3, 2020

Don't reference AssemblyMetadataAttribute in generated AssemblyInfo.cs when targeting net40 dotnet/sdk#11862

Closed

halter73 force-pushed the darc-master-7202bca0-fc71-4a03-af41-89de14869234 branch 2 times, most recently from 3e4264f to 33163a5 Compare June 3, 2020 23:28

dotnet-maestro bot merged commit 0393859 into master Jun 4, 2020

dotnet-maestro bot deleted the darc-master-7202bca0-fc71-4a03-af41-89de14869234 branch June 4, 2020 01:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[master] Update dependencies from dotnet/arcade #1678

[master] Update dependencies from dotnet/arcade #1678

dotnet-maestro bot commented Jun 1, 2020

dotnet-maestro bot commented Jun 1, 2020 •

edited

Loading

BrennanConroy commented Jun 2, 2020

dotnet-maestro bot commented Jun 2, 2020 •

edited

Loading

ajcvickers commented Jun 2, 2020

dotnet-maestro bot commented Jun 2, 2020 •

edited

Loading

smitpatel commented Jun 2, 2020

dotnet-maestro bot commented Jun 2, 2020 •

edited

Loading

halter73 commented Jun 3, 2020

dotnet-maestro bot commented Jun 3, 2020 •

edited

Loading

halter73 commented Jun 3, 2020

dotnet-maestro bot commented Jun 3, 2020 •

edited

Loading

halter73 commented Jun 3, 2020

smitpatel commented Jun 3, 2020

dotnet-maestro bot commented Jun 3, 2020 •

edited

Loading

[master] Update dependencies from dotnet/arcade #1678

[master] Update dependencies from dotnet/arcade #1678

Conversation

dotnet-maestro bot commented Jun 1, 2020

From https://github.com/dotnet/arcade

dotnet-maestro bot commented Jun 1, 2020 • edited Loading

Auto-Merge Status

BrennanConroy commented Jun 2, 2020

dotnet-maestro bot commented Jun 2, 2020 • edited Loading

Auto-Merge Status

ajcvickers commented Jun 2, 2020

dotnet-maestro bot commented Jun 2, 2020 • edited Loading

Auto-Merge Status

smitpatel commented Jun 2, 2020

dotnet-maestro bot commented Jun 2, 2020 • edited Loading

Auto-Merge Status

halter73 commented Jun 3, 2020

dotnet-maestro bot commented Jun 3, 2020 • edited Loading

Auto-Merge Status

halter73 commented Jun 3, 2020

dotnet-maestro bot commented Jun 3, 2020 • edited Loading

Auto-Merge Status

halter73 commented Jun 3, 2020

smitpatel commented Jun 3, 2020

dotnet-maestro bot commented Jun 3, 2020 • edited Loading

Auto-Merge Status

dotnet-maestro bot commented Jun 1, 2020 •

edited

Loading

dotnet-maestro bot commented Jun 2, 2020 •

edited

Loading

dotnet-maestro bot commented Jun 2, 2020 •

edited

Loading

dotnet-maestro bot commented Jun 2, 2020 •

edited

Loading

dotnet-maestro bot commented Jun 3, 2020 •

edited

Loading

dotnet-maestro bot commented Jun 3, 2020 •

edited

Loading

dotnet-maestro bot commented Jun 3, 2020 •

edited

Loading