Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency update PR #1680

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Fix dependency update PR #1680

merged 1 commit into from
Jun 3, 2020

Conversation

halter73
Copy link
Member

@halter73 halter73 commented Jun 3, 2020

This should work around the issue that's preventing #1678 (an SDK dependency update PR) from building. I'm not sure why this wasn't necessary before. See why below.

@halter73
Copy link
Member Author

halter73 commented Jun 3, 2020

Here's the file that get's generated atartifiacts/obj/ef6/Debug/net40/ef6.AssemblyInfo.cs:

//------------------------------------------------------------------------------
// <auto-generated>
//     This code was generated by a tool.
//
//     Changes to this file may cause incorrect behavior and will be lost if
//     the code is regenerated.
// </auto-generated>
//------------------------------------------------------------------------------

using System;
using System.Reflection;

[assembly: System.Reflection.AssemblyCompanyAttribute("Microsoft Corporation")]
[assembly: System.Reflection.AssemblyConfigurationAttribute("Debug")]
[assembly: System.Reflection.AssemblyCopyrightAttribute("© Microsoft Corporation. All rights reserved.")]
[assembly: System.Reflection.AssemblyFileVersionAttribute("42.42.42.42424")]
[assembly: System.Reflection.AssemblyInformationalVersionAttribute("6.5.0-dev")]
[assembly: System.Reflection.AssemblyProductAttribute("Microsoft Entity Framework")]
[assembly: System.Reflection.AssemblyTitleAttribute("ef6")]
[assembly: System.Reflection.AssemblyVersionAttribute("42.42.42.42")]
[assembly: System.Reflection.AssemblyMetadataAttribute("RepositoryUrl", "")]
[assembly: System.Resources.NeutralResourcesLanguageAttribute("en-US")]

// Generated by the MSBuild WriteCodeFragment class.

I'm not sure why this wasn't necessary before.

Thinking about this more, I'm guessing that if this file was being generated for builds targeting net40 before, it probably wasn't referencing System.Reflection.AssemblyMetadataAttribute.

@halter73
Copy link
Member Author

halter73 commented Jun 3, 2020

Found it: dotnet/sdk@d0b28b3

Filing an issue now.

@halter73
Copy link
Member Author

halter73 commented Jun 3, 2020

dotnet/sdk#11862

@halter73 halter73 merged commit f4d652d into master Jun 3, 2020
@halter73 halter73 deleted the halter73/fix-deps-update branch June 3, 2020 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants