[main] Update dependencies from dotnet/command-line-api #1826
Conversation
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
…uild 20230419.2 System.CommandLine , System.CommandLine.Rendering From Version 2.0.0-beta4.22564.1 -> To Version 2.0.0-beta4.23219.2
|
I requested a review from @jonsequitur |
|
@baronfel @adamsitnik would also be able to review this |
| internal static readonly CliOption<string> BinarylogOption = new CliOption<string>("--binarylog") | ||
| { | ||
| HelpName = "binary-log-path", | ||
| Arity = ArgumentArity.ZeroOrOne, |
There was a problem hiding this comment.
In general, you shouldn't need to set the arity unless there's some custom parsing going on. Otherwise, it's inferred from the generic type of the Option<T> or Argument<T>.
There was a problem hiding this comment.
Overall the changes from @sharwell look great, the only thing we need is to sync the version with dotnet/sdk#33157.
| @@ -5,13 +5,13 @@ | |||
| <Uri>https://github.com/dotnet/roslyn</Uri> | |||
| <Sha>d7a4cad21c39e18f3d5e1f7fa7dd3f93668066b4</Sha> | |||
| </Dependency> | |||
| <Dependency Name="System.CommandLine" Version="2.0.0-beta4.22564.1"> | |||
| <Dependency Name="System.CommandLine" Version="2.0.0-beta4.23219.2"> | |||
There was a problem hiding this comment.
We need to bump the version to be in sync with dotnet/sdk#33157
| <Dependency Name="System.CommandLine" Version="2.0.0-beta4.23219.2"> | |
| <Dependency Name="System.CommandLine" Version="2.0.0-beta4.23307.1"> |
| </Dependency> | ||
| <Dependency Name="System.CommandLine.Rendering" Version="0.4.0-alpha.22564.1"> | ||
| <Dependency Name="System.CommandLine.Rendering" Version="0.4.0-alpha.23219.2"> |
There was a problem hiding this comment.
| <Dependency Name="System.CommandLine.Rendering" Version="0.4.0-alpha.23219.2"> | |
| <Dependency Name="System.CommandLine.Rendering" Version="0.4.0-alpha.23307.1"> |
| <SystemCommandLineVersion>2.0.0-beta4.23219.2</SystemCommandLineVersion> | ||
| <SystemCommandLineRenderingVersion>0.4.0-alpha.23219.2</SystemCommandLineRenderingVersion> |
There was a problem hiding this comment.
| <SystemCommandLineVersion>2.0.0-beta4.23219.2</SystemCommandLineVersion> | |
| <SystemCommandLineRenderingVersion>0.4.0-alpha.23219.2</SystemCommandLineRenderingVersion> | |
| <SystemCommandLineVersion>2.0.0-beta4.23307.1</SystemCommandLineVersion> | |
| <SystemCommandLineRenderingVersion>0.4.0-alpha.23307.1</SystemCommandLineRenderingVersion> |
| <Uri>https://github.com/dotnet/command-line-api</Uri> | ||
| <Sha>350a618ab44932c568ae2392d7a571281baed59a</Sha> | ||
| <Sha>87704ce036fb23a4174b8290f249706aa35ab255</Sha> |
There was a problem hiding this comment.
| <Sha>87704ce036fb23a4174b8290f249706aa35ab255</Sha> | |
| <Sha>02fe27cd6a9b001c8feb7938e6ef4b3799745759</Sha> |
| <Uri>https://github.com/dotnet/command-line-api</Uri> | ||
| <Sha>350a618ab44932c568ae2392d7a571281baed59a</Sha> | ||
| <Sha>87704ce036fb23a4174b8290f249706aa35ab255</Sha> |
There was a problem hiding this comment.
| <Sha>87704ce036fb23a4174b8290f249706aa35ab255</Sha> | |
| <Sha>02fe27cd6a9b001c8feb7938e6ef4b3799745759</Sha> |
|
I don't have the write rights here hence I cannot apply my suggestion or solve the merge conflict
@sharwell is there any chance you could bump the S.CL version and solve the merge conflict? |
|
nvm I've sent #1872 |
ghost
added this to the 
dotnet-maestro
bot
deleted the
darc-main-e24473e8-6950-4d67-aabf-025da8dc8ea2
branch
|
Hey @JoeRobich can you revert this? we need to syncronize all the S.CL updates across roslyn/format/runtime/aspnet/sdk/templating and sequence them all together, and since we're getting close to p6 snap we were going to hold until after that snap occurred next week, to prevent too much churn in case we have to back it out across those repos. |
|
I knew I should have kept out of it. Will do. |
|
No good deed goes unpunished :) Thanks! |
This pull request updates the following dependencies
From https://github.com/dotnet/command-line-api