Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.CommandLine update #1872

Merged
merged 4 commits into from
Jun 15, 2023
Merged

System.CommandLine update #1872

merged 4 commits into from
Jun 15, 2023

Conversation

adamsitnik
Copy link
Member

It's #1826 but without merge conflict

dotnet-maestro bot and others added 3 commits April 27, 2023 19:22
@dotnet-maestro
Update dependencies from https://github.com/dotnet/command-line-api b…
4ea7d59 
…uild 20230419.2

System.CommandLine , System.CommandLine.Rendering
 From Version 2.0.0-beta4.22564.1 -> To Version 2.0.0-beta4.23219.2
@sharwell
Update to account for API changes
d442f76
@adamsitnik
Solving merge conflict and updating S.CL version
51b963f
@ghost ghost added the Community label Jun 12, 2023
@adamsitnik adamsitnik mentioned this pull request Jun 12, 2023
Merged
@adamsitnik
Copy link
Member Author

The Roslyn CI leg failed with package downgrade errors:

2023-06-12T16:21:26.0407699Z D:\a\_temp\temp\roslyn\src\Workspaces\CoreTestUtilities\Microsoft.CodeAnalysis.Workspaces.Test.Utilities.csproj : error NU1605: Warning As Error: Detected package downgrade: Microsoft.VisualStudio.Threading from 17.3.33 to 17.3.1-alpha. Reference the package directly from the project to select a different version.  [D:\a\_temp\temp\roslyn\Roslyn.sln]
2023-06-12T16:21:26.0423444Z D:\a\_temp\temp\roslyn\src\Workspaces\CoreTestUtilities\Microsoft.CodeAnalysis.Workspaces.Test.Utilities.csproj : error NU1605:  Microsoft.CodeAnalysis.Workspaces.Test.Utilities -> Microsoft.CodeAnalysis.EditorFeatures.Common -> Microsoft.VisualStudio.Text.UI 17.3.198 -> Microsoft.VisualStudio.CoreUtility 17.3.198 -> Microsoft.VisualStudio.Threading (>= 17.3.33)  [D:\a\_temp\temp\roslyn\Roslyn.sln]

@JoeRobich @MichaelSimons Can it be related to my changes?

@MichaelSimons
Copy link
Member

@JoeRobich @MichaelSimons Can it be related to my changes?

I will defer to the repo owners.

@adamsitnik adamsitnik mentioned this pull request Jun 13, 2023
Merged
@JoeRobich JoeRobich merged commit 3491d2c into dotnet:main Jun 15, 2023
@ghost ghost added this to the Next milestone Jun 15, 2023
@MichaelSimons
Copy link
Member

@marcpopMSFT, @baronfel - FYI - this is one of the PRs were are going to need to coordinate flowing into the SDK in order to prevent breaking source-build.

@baronfel
Copy link
Member

baronfel commented Jun 15, 2023 •
edited
Loading

yes, I asked for a revert in the other thread already with an explanation of the timing.

This was referenced Jun 15, 2023
Merged
Merged
@JoeRobich
Copy link
Member

Changes have been reverted and new PR with these changes is open as #1875

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharwell sharwell sharwell approved these changes

Assignees
No one assigned
Labels
Community
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.
5 participants
@adamsitnik @MichaelSimons @baronfel @JoeRobich @sharwell