Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move attribute enforcement from v9 to preview #17739

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

T-Gro
Copy link
Member

@T-Gro T-Gro commented Sep 15, 2024

No description provided.

@T-Gro T-Gro requested a review from a team as a code owner September 15, 2024 17:32
@T-Gro T-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Sep 15, 2024
Copy link
Contributor

github-actions bot commented Sep 15, 2024

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@vzarytovskii
Copy link
Member

@T-Gro did you confirm that this feature is causing the regression?

@T-Gro
Copy link
Member Author

T-Gro commented Sep 15, 2024

@T-Gro did you confirm that this feature is causing the regression?

See the modified tests, the "No constructors are available for the type" issue is the same as the original. (and should not be there, because the type does have a constructor)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not remember modifying this file as part of my PRs 🧐.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The negative typecheck tests do not run with langver=preview, this was only modified when the feature was enabled by default: https://github.com/dotnet/fsharp/pull/17558/files#diff-036387972a5f139a8b0f05f5b702666c5d77d961a15f0b9ac170264d79dd1c11

@vzarytovskii vzarytovskii merged commit b9df594 into main Sep 16, 2024
32 checks passed
@edgarfgp
Copy link
Contributor

@vzarytovskii should be this reverted now that #17731 has been fixed ?

@vzarytovskii
Copy link
Member

@vzarytovskii should be this reverted now that #17731 has been fixed ?

Yes, it won't make it to release though

@edgarfgp
Copy link
Contributor

@vzarytovskii should be this reverted now that #17731 has been fixed ?

Yes, it won't make it to release though

But it will be in one of the point releases right ?

@vzarytovskii
Copy link
Member

@vzarytovskii should be this reverted now that #17731 has been fixed ?

Yes, it won't make it to release though

But it will be in one of the point releases right ?

Yeah

@T-Gro T-Gro deleted the T-Gro-Move-LangFeature-AttrEnforcement branch September 17, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants