Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move attribute enforcement from v9 to preview #17739

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Move attribute enforcement from v9 to preview #17739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
444b9b1
Move attribute enforcement from v9 to preview
T-Gro Sep 15, 2024
6b65528
fantomas, bug repro in tests
T-Gro Sep 15, 2024
17af76e
bsl newline
T-Gro Sep 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Compiler/Facilities/LanguageFeatures.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,10 +213,10 @@ type LanguageVersion(versionText) =
LanguageFeature.LowerSimpleMappingsInComprehensionsToFastLoops, languageVersion90
LanguageFeature.ParsedHashDirectiveArgumentNonQuotes, languageVersion90
LanguageFeature.EmptyBodiedComputationExpressions, languageVersion90
LanguageFeature.EnforceAttributeTargets, languageVersion90
LanguageFeature.ConsistentNowarnLineDirectiveInteraction, languageVersion90

// F# preview
LanguageFeature.EnforceAttributeTargets, previewVersion // waiting for fix of https://github.com/dotnet/fsharp/issues/17731
LanguageFeature.UnmanagedConstraintCsharpInterop, previewVersion // not enabled because: https://github.com/dotnet/fsharp/issues/17509
LanguageFeature.FromEndSlicing, previewVersion // Unfinished features --- needs work
LanguageFeature.AllowAccessModifiersToAutoPropertiesGettersAndSetters, previewVersion
Expand Down
3 changes: 1 addition & 2 deletions tests/fsharp/typecheck/sigs/neg110.bsl
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not remember modifying this file as part of my PRs 🧐.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The negative typecheck tests do not run with langver=preview, this was only modified when the feature was enabled by default: https://github.com/dotnet/fsharp/pull/17558/files#diff-036387972a5f139a8b0f05f5b702666c5d77d961a15f0b9ac170264d79dd1c11

Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
neg110.fs(5,3,5,15): typecheck error FS1133: No constructors are available for the type 'NotAttribute'

neg110.fs(5,3,5,15): typecheck error FS3242: This type does not inherit Attribute, it will not work correctly with other .NET languages.

Loading