-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Alpine CI for source-build #14417
Add Alpine CI for source-build #14417
Conversation
1384fe0
to
a5ab193
Compare
@omajid, can you please rebase and target release/7.0.1xx? This will automatically flow back to main. Right now we are waiting on a new xliff version to fix the build failure this offline leg encountered. |
0785d67
to
0b30cde
Compare
The build is failing with this error:
Would it be better to wait for fixes to flow in to remove this dependency on 6.0.x? Or should I look at adding |
We should wait until the 6.0 tfm related prebuilts are removed which is slated for RC2. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
c44e0ec
to
a32c96c
Compare
@lbussell was right! We were completely missing @MichaelSimons any idea what version variable I can use for |
Looks like you can reference it by |
a32c96c
to
711f0e3
Compare
@@ -24,6 +28,7 @@ | |||
<PackageDownload Include="runtime.linux-x64.runtime.native.System.IO.Ports" Version="[$(RuntimeLinuxX64RuntimeNativeSystemIOPortsVersion)]" /> | |||
<PackageDownload Include="runtime.linux-musl-x64.Microsoft.NETCore.ILAsm" Version="[$(RuntimeLinuxX64MicrosoftNETCoreILAsmVersion)]" /> | |||
<PackageDownload Include="runtime.linux-musl-x64.Microsoft.NETCore.ILDAsm" Version="[$(RuntimeLinuxX64MicrosoftNETCoreILDAsmVersion)]" /> | |||
<PackageDownload Include="runtime.linux-musl-x64.Microsoft.NETCore.ObjWriter" Version="[$(RuntimeLinuxX64MicrosoftNETCoreRuntimeObjWriterVersion)]" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ObjWriter dependency has been removed. This is no longer necessary.
711f0e3
to
4b89306
Compare
I added my fix from #14769 here so hopefully that should fix the ASP.NET package version issue. |
@omajid I'd like to contribute to this PR now that dotnet7 is merged. It would be incredible useful for me, as we can track issues as they pop up rather than when I attack new releases with release candidates. It would also be useful to have an alpine mono build. Could I have write access as to work on it? |
By the way, the current issues will be fixed once #14549 is backported to edit 2nd edit the issue with |
c1dd2e8
to
b909dd9
Compare
@ayakael sorry about missing your message earlier. I am happy to give you commit access to this PR. Do you know how I can do that? |
The darwin error doesn't look related? |
Yes that is a known issue. |
Great to see this is passing. Thanks to all who contributed on Alpine! Is this "ready for review" after switching alpine to be a non-PR leg? |
We don't seem to have non-helix Alpine 3.16 or newer in our pre-reqs containers. Is 3.15 enough? Should we look at any other versions? |
Ideally we would pick a version supported throughout the 7.0 lifecycle (EOL May 2024), so yes I think we should look at adding the required buildtools-prereqs images. If we are going to the work of adding one, the highest ROI seems like it would be adding 3.17 images. |
This came up in dotnet/installer#14417. We are trying to add a CI leg for alpine, and alpine 3.17 most closely matches the 7.0.1xx lifecycle. The Dockerfile itself is a copy of the 3.15 Dockerfile, with 3.15 replaced with 3.17.
This came up in dotnet/installer#14417. We are trying to add a CI leg for alpine, and alpine 3.17 most closely matches the 7.0.1xx lifecycle. The Dockerfile itself is a copy of the 3.15 Dockerfile, with 3.15 replaced with 3.17.
e13a2f8
to
885bd82
Compare
885bd82
to
48c05fe
Compare
The failure is in the non-source-build leg, which uses alpine 3.15. That seems unrelated to my PR... |
Yup, same errors here: #15559. I am going to ignore these non-source-build errors and fix up the PR for merging. |
It's the release that most closely matches the .NET 7.0 lifetime.
48c05fe
to
730947d
Compare
@omajid - thanks for this contribution. I will merge after the branch opens. |
No description provided.