-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alpine source build CI leg #15765
Conversation
@@ -47,7 +51,7 @@ public void VerifyVersionFile() | |||
string sdkVersion = versionLines[1]; | |||
|
|||
// Find the expected SDK version by getting it from the SDK tarball | |||
ExtractFileFromTarball(Config.SdkTarballPath, "./sdk/*/.version", outputDir); | |||
Utilities.ExtractFileFromTarball(Config.SdkTarballPath, "./sdk/*/.version", outputDir); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is required because Alpine doesn't support the --wildcards
option like the other distros.
cc @omajid |
35ba4f1
to
6cbcc92
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s). |
b2a8e80
to
9eb49ea
Compare
9eb49ea
to
562f75e
Compare
This PR is blocked because of prebuilts. In order to build offline we need Microsoft.NETCore.App.Host.linux-musl-x64 with version (= 7.0.2). Because the Alpine CI leg was added after 7.0.2, we don't have a convenient way to produce this. Because of that, this PR is blocked until the prebuilt is removed or the 8.0 SDK updates it's known framework reference for 7.0 to a newer version so that we can grab it from the Microsoft CI leg. |
This is now ready for review. FYI @ayakael |
@@ -84,6 +88,27 @@ stages: | |||
withPreviousSDK: false # 🚫 | |||
|
|||
- ${{ if ne(variables['Build.Reason'], 'PullRequest') }}: | |||
|
|||
# CI - Stage 1 x64 legs ------------------------------------ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking for feedback on these header style comments. I am attempting to improve the readability by making it easier to quickly differentiate the various types of legs.
Port #14417 to main.
This didn't flow automatically because of the VMR and pipeline infrastructure changes.