Fix transparent default modal background #23985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
requested review from
jsuarezruiz and
tj-devel709
and removed request for
a team
mattleibow
approved these changes
Aug 5, 2024
| } | ||
|
|
||
|
|
||
| if (e.IsOneOf(Page.BackgroundColorProperty, Page.BackgroundProperty)) |
There was a problem hiding this comment.
I think BackgroundColor will always fire Background, so this is allocating an array twice and then firing twice for each time the Color is set.
There was a problem hiding this comment.
the Background Mapper will fire but the Background INPC won't fire
Here's a quick test
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
By default if the user hasn't set a background on the page, we'll set a background on the page so they can't see the content underneath the modal
Issues Fixed
Fixes #23973