-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PROTOTYPE tag #45965
Remove PROTOTYPE tag #45965
Conversation
This reverts commit 68fc0c8.
Can you also update each of these line comments to include a link to the GitHub issue tracking the TODO? |
src/Workspaces/Core/Portable/Workspace/Solution/ProjectState.cs
Outdated
Show resolved
Hide resolved
@@ -28,7 +28,7 @@ internal TrackedGeneratorDriver(GeneratorDriver generatorDriver, bool needsFullG | |||
public GeneratorDriver? GeneratorDriver { get; } | |||
public bool NeedsFullGeneration { get; } | |||
|
|||
/* PROTOTYPE: re-enable when PendingEdit is public again | |||
/* TODO: re-enable when PendingEdit is public again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 This should use #if false
instead of a block comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, updated in the PR.
Tracked those PROTOTYPEs back to #42373. Can't seem to find the issues related to those comments though. |
@chsienki do we have tracking items somewhere when we disabled the PendingEdit stuff? |
@dotnet/roslyn-ide, please review. |
* upstream/master: (304 commits) Tweak diagnostics to account for records (dotnet#46341) Diagnose precedence inversion in a warning wave (dotnet#46239) Remove PROTOTYPE tag (dotnet#45965) Only run a single pass of NullableWalker per-member (dotnet#46402) Fix crash, and offer "declare as nullable" for tuple fields (dotnet#46437) Simplify contract for RunWithShutdownBlockAsync Fix optprof plugin input check if EditorAdaptersFactoryService gives us a null buffer Cannot assign maybe-null value to TNotNull variable (dotnet#41445) Fix overload resolution to handle binary compat in the face of covariant returns (dotnet#46367) Same failure on Linux Skip some tests on Mac Added search option for inline parameter name hints Spelling tweak docs Improve comment Improve the "not exhaustive" diagnostic in the presence of a when clause. (dotnet#46143) PR feedback Use record keyword to display records (dotnet#46338) remove test that aserts .NET Standard should be prefered over .NET Framework ...
Replace instances of
PROTOTYPE
inCompiler.sln
codebase withTODO
, as the @dotnet/roslyn-compiler usesPROTOTYPE
to track feature work.