Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PROTOTYPE tag #45965

Merged
merged 6 commits into from
Jul 31, 2020
Merged

Remove PROTOTYPE tag #45965

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
68fc0c8
Updated Error Message for CS1673
Jun 3, 2020
c5858df
TODOify
Jul 14, 2020
a25c7b2
Revert "Updated Error Message for CS1673"
Jul 14, 2020
b7d2ca4
PR Changes
Jul 14, 2020
ea14e7b
PR changes
Jul 29, 2020
68aca37
Update SolutionState.TrackedGeneratorDriver.cs
Jul 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Workspaces/Core/Portable/Workspace/Solution/ProjectState.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ public override AnalyzerConfigOptions GetOptions(AdditionalText textFile)
return new WorkspaceAnalyzerConfigOptions(_projectState._lazyAnalyzerConfigSet.GetValue(CancellationToken.None).GetOptionsForSourcePath(textFile.Path));
}

// PROTOTYPE: why isn't this just a provided implementation?
// TODO: why isn't this just a provided implementation?
kevinsun-dev marked this conversation as resolved.
Show resolved Hide resolved
private sealed class WorkspaceAnalyzerConfigOptions : AnalyzerConfigOptions
{
private readonly ImmutableDictionary<string, string> _backing;
Expand Down
2 changes: 1 addition & 1 deletion src/Workspaces/Core/Portable/Workspace/Solution/SolutionState.CompilationTracker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,7 +704,7 @@ private async Task<CompilationInfo> FinalizeCompilationAsync(
}

// We will finalize the compilation by adding full contents here.
// PROTOTYPE: allow finalize compilation to incrementally update a prior version
// TODO: allow finalize compilation to incrementally update a prior version
var compilationWithoutGeneratedFiles = compilation;

if (generatorDriver.GeneratorDriver != null)
Expand Down
2 changes: 1 addition & 1 deletion src/Workspaces/Core/Portable/Workspace/Solution/SolutionState.TrackedGeneratorDriver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ internal TrackedGeneratorDriver(GeneratorDriver generatorDriver, bool needsFullG
public GeneratorDriver? GeneratorDriver { get; }
public bool NeedsFullGeneration { get; }

/* PROTOTYPE: re-enable when PendingEdit is public again
/* TODO: re-enable when PendingEdit is public again
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 This should use #if false instead of a block comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated in the PR.


public TrackedGeneratorDriver WithPendingEdit(PendingEdit pendingEdit)
{
Expand Down