Do not show unspeakable names in override completion #47979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Sep 23, 2020
src/EditorFeatures/CSharpTest/Completion/CompletionProviders/OverrideCompletionProviderTests.cs
Show resolved
Hide resolved
CyrusNajmabadi
commented
Sep 23, 2020
| } | ||
| } | ||
| if (!member.CanBeReferencedByName) | ||
| return false; |
There was a problem hiding this comment.
this is the new check. the rest is just making teh method consistent with flow control.
jmarolf
approved these changes
Sep 23, 2020
|
agree that they must remain unspeakable :) |
sharwell
approved these changes
Sep 23, 2020
...rkspaces/SharedUtilitiesAndExtensions/Compiler/Core/Extensions/INamedTypeSymbolExtensions.cs
Outdated
Show resolved
Hide resolved
…nsions/INamedTypeSymbolExtensions.cs Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
|
Hello @CyrusNajmabadi! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 12 minutes, a condition that will be fulfilled in about 4 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
…/roslyn into overriddenRecord2
|
|
||
| [WpfFact, Trait(Traits.Feature, Traits.Features.Completion)] | ||
| [WorkItem(47973, "https://github.com/dotnet/roslyn/issues/47973")] | ||
| public async Task NoCloneInOverriddenRecord() |
There was a problem hiding this comment.
Does this also need a VB test for VB code inheriting the C# Record?
This was referenced Sep 23, 2020
davidwengier
approved these changes
Sep 23, 2020
ghost
merged commit 
ghost
added this to the 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47973