-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not show unspeakable names in override completion #47979
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9adebb6
Do not show unspeakable names in override completion
CyrusNajmabadi 68d8d60
Update src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Exte…
CyrusNajmabadi 2ed1b8b
Add comment
CyrusNajmabadi 68dae93
Merge branch 'overriddenRecord2' of https://github.com/CyrusNajmabadi…
CyrusNajmabadi 002d02d
Simplify
CyrusNajmabadi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -551,30 +551,25 @@ private static void AddOverridableMembers( | |
|
||
private static bool IsOverridable(ISymbol member, INamedTypeSymbol containingType) | ||
{ | ||
if (member.IsAbstract || member.IsVirtual || member.IsOverride) | ||
{ | ||
if (member.IsSealed) | ||
{ | ||
return false; | ||
} | ||
if (!member.IsAbstract && !member.IsVirtual && !member.IsOverride) | ||
return false; | ||
|
||
if (!member.IsAccessibleWithin(containingType)) | ||
{ | ||
return false; | ||
} | ||
if (member.IsSealed) | ||
return false; | ||
|
||
switch (member.Kind) | ||
{ | ||
case SymbolKind.Event: | ||
return true; | ||
case SymbolKind.Method: | ||
return ((IMethodSymbol)member).MethodKind == MethodKind.Ordinary; | ||
case SymbolKind.Property: | ||
return !((IPropertySymbol)member).IsWithEvents; | ||
} | ||
} | ||
if (!member.CanBeReferencedByName) | ||
return false; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is the new check. the rest is just making teh method consistent with flow control. |
||
|
||
return false; | ||
if (!member.IsAccessibleWithin(containingType)) | ||
return false; | ||
|
||
return member switch | ||
{ | ||
IEventSymbol => true, | ||
IMethodSymbol { MethodKind: MethodKind.Ordinary } => true, | ||
IPropertySymbol { IsWithEvents: false } => true, | ||
_ => false, | ||
}; | ||
} | ||
|
||
private static void RemoveOverriddenMembers( | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this also need a VB test for VB code inheriting the C# Record?