Remove InternalsVisibleTo from System.Collections.Immutable. (#107872)

* Remove InternalsVisibleTo from System.Collections.Immutable. * Remove a few unneeded internal interfaces. * Replace IOrderedCollection<T> with IReadOnlyList<T> * Remove empty folder. * Avoid trimming necessary reflection metadata. * Do not look up IBinaryTree interface. * Revert "Avoid trimming necessary reflection metadata." This reverts commit d3cf8f9. * Remove IBinaryTree interface.
dotnet · Sep 18, 2024 · 9eb48cd · 9eb48cd
1 parent f748f06
commit 9eb48cd
Show file tree

Hide file tree

Showing 40 changed files with 286 additions and 757 deletions.
diff --git a/src/libraries/System.Collections.Immutable/src/Properties/InternalsVisibleTo.cs b/src/libraries/System.Collections.Immutable/src/Properties/InternalsVisibleTo.cs
diff --git a/src/libraries/System.Collections.Immutable/src/System.Collections.Immutable.csproj b/src/libraries/System.Collections.Immutable/src/System.Collections.Immutable.csproj
@@ -11,7 +11,6 @@ The System.Collections.Immutable library is built-in as part of the shared frame
   </PropertyGroup>
 
   <ItemGroup>
-    <Compile Include="Properties\InternalsVisibleTo.cs" />
     <Compile Include="System\Polyfills.cs" />
     <Compile Include="System\Collections\ThrowHelper.cs" />
     <Compile Include="$(CoreLibSharedDir)System\Collections\HashHelpers.cs" Link="System\Collections\HashHelpers.cs" />
@@ -68,26 +67,20 @@ The System.Collections.Immutable library is built-in as part of the shared frame
     <Compile Include="System\Collections\Frozen\String\OrdinalStringFrozenSet_RightJustifiedSubstring.cs" />
     <Compile Include="System\Collections\Frozen\String\OrdinalStringFrozenSet_RightJustifiedSingleChar.cs" />
 
-    <Compile Include="System\Collections\Generic\IHashKeyCollection.cs" />
-    <Compile Include="System\Collections\Generic\ISortKeyCollection.cs" />
-
     <Compile Include="System\Collections\Immutable\AllocFreeConcurrentStack.cs" />
     <Compile Include="System\Collections\Immutable\DictionaryEnumerator.cs" />
     <Compile Include="System\Collections\Immutable\DisposableEnumeratorAdapter_2.cs" />
-    <Compile Include="System\Collections\Immutable\IBinaryTree.cs" />
     <Compile Include="System\Collections\Immutable\IImmutableArray.cs" />
     <Compile Include="System\Collections\Immutable\IImmutableDictionary.cs" />
     <Compile Include="System\Collections\Immutable\IImmutableDictionaryInternal.cs" />
     <Compile Include="System\Collections\Immutable\IImmutableList.cs" />
-    <Compile Include="System\Collections\Immutable\IImmutableListQueries.cs" />
     <Compile Include="System\Collections\Immutable\IImmutableQueue.cs" />
     <Compile Include="System\Collections\Immutable\IImmutableSet.cs" />
     <Compile Include="System\Collections\Immutable\IImmutableStack.cs" />
     <Compile Include="System\Collections\Immutable\ImmutableHashSet_1.HashBucketByValueEqualityComparer.cs" />
     <Compile Include="System\Collections\Immutable\ImmutableHashSet_1.HashBucketByRefEqualityComparer.cs" />
     <Compile Include="System\Collections\Immutable\IStrongEnumerable_2.cs" />
     <Compile Include="System\Collections\Immutable\IStrongEnumerator_1.cs" />
-    <Compile Include="System\Collections\Immutable\IOrderedCollection.cs" />
     <Compile Include="System\Collections\Immutable\ImmutableArray.cs" />
     <Compile Include="System\Collections\Immutable\ImmutableArray_1.Builder.cs" />
     <Compile Include="System\Collections\Immutable\ImmutableArray_1.Builder.DebuggerProxy.cs" />

diff --git a/...braries/System.Collections.Immutable/src/System/Collections/Generic/IHashKeyCollection.cs b/...braries/System.Collections.Immutable/src/System/Collections/Generic/IHashKeyCollection.cs
diff --git a/...braries/System.Collections.Immutable/src/System/Collections/Generic/ISortKeyCollection.cs b/...braries/System.Collections.Immutable/src/System/Collections/Generic/ISortKeyCollection.cs
diff --git a/src/libraries/System.Collections.Immutable/src/System/Collections/Immutable/IBinaryTree.cs b/src/libraries/System.Collections.Immutable/src/System/Collections/Immutable/IBinaryTree.cs