Remove InternalsVisibleTo from System.Collections.Immutable. #107872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
reviewed
Sep 16, 2024
| <Compile Include="..\src\System\Collections\Frozen\String\Hashing.cs" Link="System\Collections\Frozen\String\Hashing.cs" /> | ||
| <Compile Include="..\src\System\Collections\Frozen\String\KeyAnalyzer.cs" Link="System\Collections\Frozen\String\KeyAnalyzer.cs" /> | ||
| <Compile Include="..\src\System\Collections\Immutable\IBinaryTree.cs" Link="System\Collections\Immutable\IBinaryTree.cs" /> | ||
| <Compile Include="..\src\Validation\Requires.cs" Link="Validation\Requires.cs" /> |
There was a problem hiding this comment.
We should probably follow up to separate these out further, but for now this PR is definitely a good step in the right direction.
|
Out of curiosity, I tried building S.C.I with and without this PR. This reduces its size on disk by ~5%. |
stephentoub
reviewed
Sep 16, 2024
src/libraries/System.Collections.Immutable/src/System.Collections.Immutable.csproj
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Sep 16, 2024
|
@vitek-karas could you suggest any workarounds for enabling private field access in blazor-wasm? My change in d3cf8f9 doesn't seem to do it. |
3 tasks
This was referenced Sep 18, 2024
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
…107872) * Remove InternalsVisibleTo from System.Collections.Immutable. * Remove a few unneeded internal interfaces. * Replace IOrderedCollection<T> with IReadOnlyList<T> * Remove empty folder. * Avoid trimming necessary reflection metadata. * Do not look up IBinaryTree interface. * Revert "Avoid trimming necessary reflection metadata." This reverts commit d3cf8f9. * Remove IBinaryTree interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #107848.