Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS tests are failing deterministically in CI #48751

Closed
ViktorHofer opened this issue Feb 25, 2021 · 14 comments · Fixed by #52377
Closed

DNS tests are failing deterministically in CI #48751

ViktorHofer opened this issue Feb 25, 2021 · 14 comments · Fixed by #52377
Assignees
Labels
area-System.Net disabled-test The test is disabled in source code against the issue test-run-core Test failures in .NET Core test runs
Milestone

Comments

@ViktorHofer
Copy link
Member

image

https://dev.azure.com/dnceng/public/_build/results?buildId=1011172&view=ms.vss-test-web.build-test-results-tab

System.Net.Internals.SocketExceptionFactory+ExtendedSocketException : Name or service not known
 at System.Net.Dns.GetHostEntryOrAddressesCore(String hostName, Boolean justAddresses, AddressFamily addressFamily) in /_/src/libraries/System.Net.NameResolution/src/System/Net/Dns.cs:line 404
   at System.Net.Dns.GetHostEntryCore(String hostName, AddressFamily addressFamily) in /_/src/libraries/System.Net.NameResolution/src/System/Net/Dns.cs:line 385
   at System.Net.Dns.GetHostByName(String hostName) in /_/src/libraries/System.Net.NameResolution/src/System/Net/Dns.cs:line 272
   at System.Net.NameResolution.Tests.GetHostByNameTest.DnsObsoleteGetHostByName_EmptyString_ReturnsHostName() in /_/src/libraries/System.Net.NameResolution/tests/FunctionalTests/GetHostByNameTest.cs:line 108

We probably need to disable the failing tests right now as apparently something changed in the dns detection which is causing these tests to fail deterministically in CI.

cc @dotnet/ncl

@ViktorHofer ViktorHofer added area-System.Net blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' labels Feb 25, 2021
@ViktorHofer ViktorHofer added this to the 6.0.0 milestone Feb 25, 2021
@ghost
Copy link

ghost commented Feb 25, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

image

https://dev.azure.com/dnceng/public/_build/results?buildId=1011172&view=ms.vss-test-web.build-test-results-tab

System.Net.Internals.SocketExceptionFactory+ExtendedSocketException : Name or service not known
 at System.Net.Dns.GetHostEntryOrAddressesCore(String hostName, Boolean justAddresses, AddressFamily addressFamily) in /_/src/libraries/System.Net.NameResolution/src/System/Net/Dns.cs:line 404
   at System.Net.Dns.GetHostEntryCore(String hostName, AddressFamily addressFamily) in /_/src/libraries/System.Net.NameResolution/src/System/Net/Dns.cs:line 385
   at System.Net.Dns.GetHostByName(String hostName) in /_/src/libraries/System.Net.NameResolution/src/System/Net/Dns.cs:line 272
   at System.Net.NameResolution.Tests.GetHostByNameTest.DnsObsoleteGetHostByName_EmptyString_ReturnsHostName() in /_/src/libraries/System.Net.NameResolution/tests/FunctionalTests/GetHostByNameTest.cs:line 108

We probably need to disable the failing tests right now as apparently something changed in the dns detection which is causing these tests to fail deterministically in CI.

cc @dotnet/ncl

Author: ViktorHofer
Assignees: -
Labels:

area-System.Net, blocking-clean-ci

Milestone: 6.0.0

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Feb 25, 2021
@ManickaP ManickaP removed the untriaged New issue has not been triaged by the area owner label Feb 25, 2021
@wfurt
Copy link
Member

wfurt commented Feb 25, 2021

Do you know if anything changed with infrastructure @MattGal ? From the logs it seems like the instance cannot resolve it's own name. I'll keep looking as it is not clear why this would happen only on particular distro.

@MattGal
Copy link
Member

MattGal commented Feb 25, 2021

Do you know if anything changed with infrastructure @MattGal ? From the logs it seems like the instance cannot resolve it's own name. I'll keep looking as it is not clear why this would happen only on particular distro.

Interesting; I know of no intentional changes from this but Weds. is rollout days so if something changed, it would have been yesterday. Taking a look.

@MattGal
Copy link
Member

MattGal commented Feb 25, 2021

Do you know if anything changed with infrastructure @MattGal ? From the logs it seems like the instance cannot resolve it's own name. I'll keep looking as it is not clear why this would happen only on particular distro.

Interesting; I know of no intentional changes from this but Weds. is rollout days so if something changed, it would have been yesterday. Taking a look.

Ah. SLES 15. Yes, we did update this one yesterday, because SUSE deleted the SLES 15 SP1 image from the gallery, forcing us onto SP2. I'll check it out and see if there's anything we can do and report back. Tracking issue: https://github.com/dotnet/core-eng/issues/12333

@wfurt
Copy link
Member

wfurt commented Feb 25, 2021

thanks @MattGal. If needed, I can help with the investigation.

@wfurt
Copy link
Member

wfurt commented Feb 25, 2021

cc @dnceng for visibility.

@MattGal
Copy link
Member

MattGal commented Feb 25, 2021

@dotnet/dnceng also

@MattGal
Copy link
Member

MattGal commented Feb 25, 2021

the problem comes from including git-core, I am looking at working around it.

@VincentBu
Copy link
Contributor

Failed again in runtime 20210225.61

Failed test:

net6.0-Linux-Release-x64-CoreCLR_release-SLES.15.Amd64.Open

 -System.Net.NameResolution.Tests.GetHostByNameTest.DnsObsoleteGetHostByName_EmptyString_ReturnsHostName

Error message:

System.Net.Internals.SocketExceptionFactory+ExtendedSocketException : Name or service not known


Stack trace
   at System.Net.Dns.GetHostEntryOrAddressesCore(String hostName, Boolean justAddresses, AddressFamily addressFamily) in /_/src/libraries/System.Net.NameResolution/src/System/Net/Dns.cs:line 404
   at System.Net.Dns.GetHostEntryCore(String hostName, AddressFamily addressFamily) in /_/src/libraries/System.Net.NameResolution/src/System/Net/Dns.cs:line 385
   at System.Net.Dns.GetHostByName(String hostName) in /_/src/libraries/System.Net.NameResolution/src/System/Net/Dns.cs:line 272
   at System.Net.NameResolution.Tests.GetHostByNameTest.DnsObsoleteGetHostByName_EmptyString_ReturnsHostName() in /_/src/libraries/System.Net.NameResolution/tests/FunctionalTests/GetHostByNameTest.cs:line 108

@stephentoub stephentoub added disabled-test The test is disabled in source code against the issue and removed blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' labels Feb 26, 2021
@MattGal
Copy link
Member

MattGal commented Feb 26, 2021

@VincentBu yes, while I have a lead on what caused this, the earliest this will be fixed on the machines is next Weds. I was under the impression from @wfurt this test was disabled on that platform for the time being?

@ViktorHofer
Copy link
Member Author

Yes, the tests are already disabled.

@karelz
Copy link
Member

karelz commented Apr 23, 2021

@MattGal @ViktorHofer did the DNS get fixed in CI? Should we re-enable the tests?

@MattGal
Copy link
Member

MattGal commented Apr 23, 2021

@MattGal @ViktorHofer did the DNS get fixed in CI? Should we re-enable the tests?

It's hard to be certain since the tests are off, but in retrospect we were definitely having global issues with DNS in Azure machines that have subsided (down to a single domain that may have problems from creating hosts fast?) in the March timeframe.

I'd say it's worth a try, since various things have changed since Mar. 3. I'll take a stab when I finish my inbox but the tricky part is with your test disabled I don't have a simple repro path.

@karelz karelz added the test-run-core Test failures in .NET Core test runs label May 4, 2021
@MattGal
Copy link
Member

MattGal commented May 4, 2021

@karelz sorry for the delay. The workaround I made for the strange symptom from before (inability to resolve the local host) is still holding, so yes you should reenable these tests on SLES 15.

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label May 6, 2021
@karelz karelz assigned karelz and unassigned wfurt May 6, 2021
karelz added a commit that referenced this issue May 6, 2021
The tests were failing previously due to infra on SLES, which is now fixed. We can re-enable the tests.

Fixes #48751
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label May 6, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net disabled-test The test is disabled in source code against the issue test-run-core Test failures in .NET Core test runs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants