Re-enable DNS tests on SLES, which were failing due to infra - see do…

…tnet#48751
karelz · May 6, 2021 · cd659a9 · cd659a9
1 parent 8f3ac9b
commit cd659a9
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 28 deletions.
diff --git a/src/libraries/System.Net.NameResolution/tests/FunctionalTests/GetHostByNameTest.cs b/src/libraries/System.Net.NameResolution/tests/FunctionalTests/GetHostByNameTest.cs
@@ -105,12 +105,6 @@ public void DnsObsoleteGetHostByName_IPv6String_ReturnsOnlyGivenIP()
         [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotArm64Process))] // [ActiveIssue("https://github.com/dotnet/runtime/issues/27622")]
         public void DnsObsoleteGetHostByName_EmptyString_ReturnsHostName()
         {
-            if (PlatformDetection.IsSLES)
-            {
-                // [ActiveIssue("https://github.com/dotnet/runtime/issues/48751")]
-                return;
-            }
-
             IPHostEntry entry = Dns.GetHostByName("");
 
             // DNS labels should be compared as case insensitive for ASCII characters. See RFC 4343.
@@ -121,12 +115,6 @@ public void DnsObsoleteGetHostByName_EmptyString_ReturnsHostName()
         [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotArm64Process), nameof(PlatformDetection.IsThreadingSupported))] // [ActiveIssue("https://github.com/dotnet/runtime/issues/27622")]
         public void DnsObsoleteBeginEndGetHostByName_EmptyString_ReturnsHostName()
         {
-            if (PlatformDetection.IsSLES)
-            {
-                // [ActiveIssue("https://github.com/dotnet/runtime/issues/48751")]
-                return;
-            }
-
             IPHostEntry entry = Dns.EndGetHostByName(Dns.BeginGetHostByName("", null, null));
 
             // DNS labels should be compared as case insensitive for ASCII characters. See RFC 4343.

diff --git a/src/libraries/System.Net.NameResolution/tests/FunctionalTests/GetHostEntryTest.cs b/src/libraries/System.Net.NameResolution/tests/FunctionalTests/GetHostEntryTest.cs
@@ -27,12 +27,6 @@ public async Task Dns_GetHostEntryAsync_IPAddress_Ok()
         [InlineData(TestSettings.LocalHost)]
         public async Task Dns_GetHostEntry_HostString_Ok(string hostName)
         {
-            if (PlatformDetection.IsSLES)
-            {
-                // [ActiveIssue("https://github.com/dotnet/runtime/issues/48751")]
-                return;
-            }
-
             try
             {
                 await TestGetHostEntryAsync(() => Task.FromResult(Dns.GetHostEntry(hostName)));
@@ -77,20 +71,11 @@ public async Task Dns_GetHostEntry_HostString_Ok(string hostName)
         }
 
         [ActiveIssue("https://github.com/dotnet/runtime/issues/1488", TestPlatforms.OSX)]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/48751", TestPlatforms.Linux)]
         [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsNotArm64Process))] // [ActiveIssue("https://github.com/dotnet/runtime/issues/27622")]
         [InlineData("")]
         [InlineData(TestSettings.LocalHost)]
-        public async Task Dns_GetHostEntryAsync_HostString_Ok(string hostName)
-        {
-            if (PlatformDetection.IsSLES)
-            {
-                // [ActiveIssue("https://github.com/dotnet/runtime/issues/48751")]
-                return;
-            }
-
+        public async Task Dns_GetHostEntryAsync_HostString_Ok(string hostName) =>
             await TestGetHostEntryAsync(() => Dns.GetHostEntryAsync(hostName));
-        }
 
         [Fact]
         public async Task Dns_GetHostEntryAsync_IPString_Ok() =>