Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure:System.Diagnostics.Metrics.Tests.MetricEventSourceTests.EventSourceFiltersInstruments #55313

Closed
VincentBu opened this issue Jul 8, 2021 · 5 comments · Fixed by #56654
Closed

Test failure:System.Diagnostics.Metrics.Tests.MetricEventSourceTests.EventSourceFiltersInstruments #55313

VincentBu opened this issue Jul 8, 2021 · 5 comments · Fixed by #56654
Assignees
@noahfalk
Labels
arch-arm64 area-System.Diagnostics.Metric os-linux Linux OS (any supported distro)
Milestone
6.0.0

Comments

@VincentBu
Copy link
Contributor

Run: runtime 20210707.124
Failed test:

net6.0-Linux-Release-arm64-CoreCLR_checked-(Alpine.312.Arm64.Open)Ubuntu.1804.ArmArch.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:alpine-3.12-helix-arm64v8-20200602002604-25f8a3e

- System.Diagnostics.Metrics.Tests.MetricEventSourceTests.EventSourceFiltersInstruments

Error message

Assert.True() Failure
Expected: True
Actual:   False


Stack trace
   at System.Diagnostics.Metrics.Tests.MetricEventSourceTests.AssertCounterEventsPresent(EventWrittenEventArgs[] events, String meterName, String instrumentName, String tags, String expectedUnit, String[] expectedRates) in /_/src/libraries/System.Diagnostics.DiagnosticSource/tests/MetricEventSourceTests.cs:line 710
   at System.Diagnostics.Metrics.Tests.MetricEventSourceTests.EventSourceFiltersInstruments() in /_/src/libraries/System.Diagnostics.DiagnosticSource/tests/MetricEventSourceTests.cs:line 292
@VincentBu VincentBu added arch-arm64 os-linux Linux OS (any supported distro) labels Jul 8, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.Diagnostics.Tracing untriaged New issue has not been triaged by the area owner labels Jul 8, 2021
@ghost
Copy link

ghost commented Jul 8, 2021

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details

Run: runtime 20210707.124
Failed test:

net6.0-Linux-Release-arm64-CoreCLR_checked-(Alpine.312.Arm64.Open)Ubuntu.1804.ArmArch.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:alpine-3.12-helix-arm64v8-20200602002604-25f8a3e

- System.Diagnostics.Metrics.Tests.MetricEventSourceTests.EventSourceFiltersInstruments

Error message

Assert.True() Failure
Expected: True
Actual:   False


Stack trace
   at System.Diagnostics.Metrics.Tests.MetricEventSourceTests.AssertCounterEventsPresent(EventWrittenEventArgs[] events, String meterName, String instrumentName, String tags, String expectedUnit, String[] expectedRates) in /_/src/libraries/System.Diagnostics.DiagnosticSource/tests/MetricEventSourceTests.cs:line 710
   at System.Diagnostics.Metrics.Tests.MetricEventSourceTests.EventSourceFiltersInstruments() in /_/src/libraries/System.Diagnostics.DiagnosticSource/tests/MetricEventSourceTests.cs:line 292
Author: VincentBu
Assignees: -
Labels:

arch-arm64, area-System.Diagnostics.Tracing, os-linux, untriaged
Milestone: -

@tarekgh tarekgh added area-System.Diagnostics.Metric and removed untriaged New issue has not been triaged by the area owner area-System.Diagnostics.Tracing labels Jul 8, 2021
@tarekgh
Copy link
Member

tarekgh commented Jul 8, 2021

@noahfalk could you please have a look at this one?

@tarekgh tarekgh added this to the 6.0.0 milestone Jul 8, 2021
@SingleAccretion SingleAccretion mentioned this issue Jul 8, 2021
Merged
@tarekgh tarekgh mentioned this issue Jul 10, 2021
Merged
@noahfalk
Copy link
Member

This is hopefully resolved with #55385, if it fails again please reopen and I can investigate further

@MihaZupan
Copy link
Member

Failed again in #56614:
https://helix.dot.net/api/2019-06-17/jobs/5702a0df-b9d9-4ab2-8727-84d96b73d659/workitems/System.Diagnostics.DiagnosticSource.Tests/console

@MihaZupan MihaZupan reopened this Jul 30, 2021
@MihaZupan MihaZupan mentioned this issue Jul 30, 2021
Merged
noahfalk added a commit to noahfalk/runtime that referenced this issue Jul 30, 2021
@noahfalk
Fix MetricsEventSource tests
1cadd17 
Fixes dotnet#55313

The metrics test has to collect different events that
update counters in a specific interval of time. Previously
those intervals were 1 second long but ARM64 appears to
run slowly enough that some of the events didn't complete
until 2 seconds had passed.

I increased the intervals to 5 seconds each. We could go
longer to reduce the risk further, but I am trying not to
make the tests take overly long.
@noahfalk noahfalk mentioned this issue Jul 30, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 30, 2021
noahfalk added a commit that referenced this issue Aug 4, 2021
@noahfalk
Fix MetricsEventSource tests (#56654)
2360161 
Fixes #55313

The metrics test has to collect different events that
update counters in a specific interval of time. Previously
those intervals were 1 second long but ARM64 appears to
run slowly enough that some of the events didn't complete
until 2 seconds had passed.

I increased the intervals to 5 seconds each. We could go
longer to reduce the risk further, but I am trying not to
make the tests take overly long.
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 4, 2021
@noahfalk
Copy link
Member

noahfalk commented Aug 4, 2021

New issue is hopefully resolved. Ultimately this test is timing dependent so we can't guarantee it works, we can just keep increasing the allowed time window making it increasingly likely that code runs fast enough to complete in the expected time. The penalty for being overly conservative is that we make the test take a very long time to run.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@noahfalk noahfalk

Labels
arch-arm64 area-System.Diagnostics.Metric os-linux Linux OS (any supported distro)
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Fix MetricsEventSource tests noahfalk/runtime
4 participants
@noahfalk @tarekgh @MihaZupan @VincentBu