Skip to content

Commit

Permalink
Fix MetricsEventSource tests
Browse files Browse the repository at this point in the history
Fixes dotnet#55313

The metrics test has to collect different events that
update counters in a specific interval of time. Previously
those intervals were 1 second long but ARM64 appears to
run slowly enough that some of the events didn't complete
until 2 seconds had passed.

I increased the intervals to 5 seconds each. We could go
longer to reduce the risk further, but I am trying not to
make the tests take overly long.
  • Loading branch information
noahfalk committed Jul 30, 2021
1 parent 3bd0acf commit 1cadd17
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ namespace System.Diagnostics.Metrics.Tests
public class MetricEventSourceTests
{
ITestOutputHelper _output;
const double IntervalSecs = 1;
const double IntervalSecs = 5;
static readonly TimeSpan s_waitForEventTimeout = TimeSpan.FromSeconds(60);

public MetricEventSourceTests(ITestOutputHelper output)
Expand Down

0 comments on commit 1cadd17

Please sign in to comment.