Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure: JIT/Directed/coverage/oldtests/stfldstatic2_r/stfldstatic2_r.dll #91647

Closed
BruceForstall opened this issue Sep 5, 2023 · 3 comments · Fixed by #91652
Closed

Test failure: JIT/Directed/coverage/oldtests/stfldstatic2_r/stfldstatic2_r.dll #91647

BruceForstall opened this issue Sep 5, 2023 · 3 comments · Fixed by #91652
Assignees
@EgorBo
Labels
arch-arm64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs os-mac-os-x macOS aka OSX
Milestone
9.0.0

Comments

@BruceForstall
Copy link
Member

pipeline: runtime-coreclr outerloop
coreclr osx arm64 Checked no_tiered_compilation @ OSX.1200.ARM64.Open
Directed_1 Work Item

https://dev.azure.com/dnceng-public/public/_build/results?buildId=392066&view=ms.vss-test-web.build-test-results-tab&runId=8427280&paneView=debug&resultId=120604

(failure started with runtime-coreclr outerloop 20230831.3)

12:57:21.890 Running test: JIT/Directed/coverage/oldtests/stfldstatic2_r/stfldstatic2_r.dll
Fatal error. System.Runtime.InteropServices.SEHException (0x80004005): External component has thrown an exception.
   at stfldstatic2.Main()
   at Program.<<Main>$>g__TestExecutor171|0_172(System.IO.StreamWriter, System.IO.StreamWriter, <>c__DisplayClass0_0 ByRef)
   at Program.<Main>$(System.String[])
[createdump] Invalid process id: task_for_pid(58591) FAILED (os/kern) failure (5)
[createdump] This failure may be because createdump or the application is not properly signed and entitled.
[createdump] Target process is alive
[createdump] Failure took 0ms
waitpid() returned successfully (wstatus 0000ff00) WEXITSTATUS ff WTERMSIG 0
App Exit Code: 22
Expected: 100
Actual: 22
END EXECUTION - FAILED

Maybe related to #89681 @EgorBo ?
@BruceForstall BruceForstall added arch-arm64 os-mac-os-x macOS aka OSX area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Sep 5, 2023
@BruceForstall BruceForstall added this to the 9.0.0 milestone Sep 5, 2023
@ghost
Copy link

ghost commented Sep 5, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

pipeline: runtime-coreclr outerloop
coreclr osx arm64 Checked no_tiered_compilation @ OSX.1200.ARM64.Open
Directed_1 Work Item

https://dev.azure.com/dnceng-public/public/_build/results?buildId=392066&view=ms.vss-test-web.build-test-results-tab&runId=8427280&paneView=debug&resultId=120604

(failure started with runtime-coreclr outerloop 20230831.3)

12:57:21.890 Running test: JIT/Directed/coverage/oldtests/stfldstatic2_r/stfldstatic2_r.dll
Fatal error. System.Runtime.InteropServices.SEHException (0x80004005): External component has thrown an exception.
   at stfldstatic2.Main()
   at Program.<<Main>$>g__TestExecutor171|0_172(System.IO.StreamWriter, System.IO.StreamWriter, <>c__DisplayClass0_0 ByRef)
   at Program.<Main>$(System.String[])
[createdump] Invalid process id: task_for_pid(58591) FAILED (os/kern) failure (5)
[createdump] This failure may be because createdump or the application is not properly signed and entitled.
[createdump] Target process is alive
[createdump] Failure took 0ms
waitpid() returned successfully (wstatus 0000ff00) WEXITSTATUS ff WTERMSIG 0
App Exit Code: 22
Expected: 100
Actual: 22
END EXECUTION - FAILED

Maybe related to #89681 @EgorBo ?

Author: BruceForstall
Assignees: -
Labels:

arch-arm64, os-mac-os-x, area-CodeGen-coreclr
Milestone: 9.0.0

@EgorBo EgorBo self-assigned this Sep 5, 2023
@BruceForstall BruceForstall mentioned this issue Sep 5, 2023
Closed
BruceForstall added a commit to BruceForstall/runtime that referenced this issue Sep 5, 2023
@BruceForstall
Disable stfldstatic2_r, Box_Unbox_volatile on osx-arm64
b5bd71d 
Tracking: dotnet#91647, dotnet#91648
@BruceForstall BruceForstall added the blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs label Sep 5, 2023
@BruceForstall BruceForstall mentioned this issue Sep 5, 2023
Closed
@EgorBo
Copy link
Member

EgorBo commented Sep 5, 2023 •
edited
Loading

Yes, seems like ldapur is the culprit, here is the asm diff:
image

it looks correct to me (x0 is last-use) so most likely the problem is on the encoding side, I'll check and file a fix shortly

@EgorBo
Copy link
Member

EgorBo commented Sep 5, 2023 

1D404011          ldapur  s17, [x0, #0x04]

@EgorBo EgorBo mentioned this issue Sep 6, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Sep 6, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Sep 6, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@EgorBo EgorBo

Labels
arch-arm64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs os-mac-os-x macOS aka OSX
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Fix ldapur instruction EgorBo/runtime-1
2 participants
@EgorBo @BruceForstall