Fix ldapur instruction #91652
Merged
Fix ldapur instruction #91652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsLDAPUR* doesn't support fp registers (so we'll fallback to ldr+dmb for them). Also I added "addrIsAligned" check that we already have for ldar (which might fault on mis-aligned access, e.g.) PTAL @BruceForstall @TIHan @dotnet/jit-contrib
|
BruceForstall
approved these changes
Sep 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91648
Fixes #91647
The issue is that LDAPUR doesn't support fp regs, I made a small clean up and now it should ignore those (just like for existing ldar)
PTAL @BruceForstall @TIHan @dotnet/jit-contrib