Use separate key instances for span/array/array+offset test classes #34199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the key object generation was done in the algorithm-specific base class, the triplet of interface types was using the key instances in parallel. By moving the static variable (and initialization thereof) to each of the derived classes, the key objects are unique per class, which matches the test parallelism. Making the classes be part of the same test collection would also solve this problem, which would save on a few random keygens, but would likely overall take more time due to the number of tests that would be moved to sequential execution.
bartonjs
added
area-System.Security
test-bug
stephentoub
approved these changes
Mar 27, 2020
|
Hello @bartonjs! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the key object generation was done in the algorithm-specific base class,
the triplet of interface types was using the key instances in parallel.
By moving the static variable (and initialization thereof) to each of the derived
classes, the key objects are unique per class, which matches the test parallelism.
Making the classes be part of the same test collection would also solve this problem,
which would save on a few random keygens, but would likely overall take more
time due to the number of tests that would be moved to sequential execution.
Fixes #34045.