Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate key instances for span/array/array+offset test classes #34199

Merged
merged 1 commit into from
Mar 28, 2020

Commits on Mar 27, 2020

  1. Use separate key instances for span/array/array+offset test classes

    Because the key object generation was done in the algorithm-specific base class,
    the triplet of interface types was using the key instances in parallel.
    
    By moving the static variable (and initialization thereof) to each of the derived
    classes, the key objects are unique per class, which matches the test parallelism.
    
    Making the classes be part of the same test collection would also solve this problem,
    which would save on a few random keygens, but would likely overall take more
    time due to the number of tests that would be moved to sequential execution.
    bartonjs committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    c03be0f View commit details
    Browse the repository at this point in the history