Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasm cross compiler #47011

Merged
merged 24 commits into from
Jan 19, 2021
Merged

Wasm cross compiler #47011

merged 24 commits into from
Jan 19, 2021

Conversation

directhex
Copy link
Member

@directhex directhex commented Jan 14, 2021

Leverage the infra built for the Android cross compiler, to make a Wasm cross compiler.

@ghost
Copy link

ghost commented Jan 14, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Leverage the infra built for the Android cross compiler, to make a Wasm cross compiler.

Right now the yaml isn't wired up to do the actual build (just generate offsets). Works locally; will fill in the missing yaml on Friday

Author: directhex
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: -

@directhex directhex marked this pull request as ready for review January 19, 2021 15:50
@directhex
Copy link
Member Author

@steveisok steveisok self-requested a review January 19, 2021 16:01
eng/Subsets.props Outdated Show resolved Hide resolved
Copy link
Member

@akoeplinger akoeplinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from the naming comments

@ghost
Copy link

ghost commented Jan 19, 2021

Hello @directhex!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@directhex
Copy link
Member Author

Merging despite the failure, as the failure is unrelated infra #47185

@directhex directhex merged commit 1ab58a8 into dotnet:master Jan 19, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Feb 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants