Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasm cross compiler #47011

Merged
merged 24 commits into from
Jan 19, 2021
Merged
Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
50f4abb
Allow no EMSDK for cross-compiler
directhex Jan 14, 2021
a3bce8d
Don't try to include file not made during AOT on Browser
directhex Jan 14, 2021
e40b96f
Move BuildMonoCrossAOT from a bool to a Subset-esque string
directhex Jan 14, 2021
d3a3c7d
Generate wasm offsets
directhex Jan 14, 2021
aed7f58
Add new offset generation to non-official builds too. Oops
directhex Jan 14, 2021
d289447
Deal with default case when generating offsets only
directhex Jan 14, 2021
3f3c926
We override the OS, so can't switch on it
directhex Jan 15, 2021
e97f7d4
Merge remote-tracking branch 'origin/master' into wasm-cross
directhex Jan 15, 2021
00de7a9
We're being skipped again
directhex Jan 15, 2021
5351a01
Grr
directhex Jan 15, 2021
e1d2e12
Try another time. Merges passing in the night.
directhex Jan 15, 2021
2fb0e48
Merge remote-tracking branch 'origin/master' into wasm-cross
directhex Jan 15, 2021
7b24cc2
Merge remote-tracking branch 'origin/master' into wasm-cross
directhex Jan 19, 2021
8bcc13e
Try and make the yaml consume both offsets
directhex Jan 19, 2021
8600305
Clean up last commit, which went surprisingly well
directhex Jan 19, 2021
89331d1
Actually consume all offsets from parameter
directhex Jan 19, 2021
0a73e3f
Yaml 🤷‍♂️
directhex Jan 19, 2021
1683134
It's not crossandroid any more, is it?
directhex Jan 19, 2021
aaf7aba
Official version
directhex Jan 19, 2021
5539e7a
Fix typo
directhex Jan 19, 2021
e263c2c
Fix typo in typo
directhex Jan 19, 2021
c12e193
Cleanups
directhex Jan 19, 2021
7e07232
Variable rename suggestion from Alex
directhex Jan 19, 2021
20b1ef7
More better variable names from Alex
directhex Jan 19, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions eng/Subsets.props
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
<DefaultMonoSubsets Condition="'$(MonoEnableLLVM)' == 'true' and '$(MonoLLVMDir)' == ''">mono.llvm+</DefaultMonoSubsets>
<DefaultMonoSubsets Condition="'$(MonoAOTEnableLLVM)' == 'true' and '$(MonoAOTLLVMDir)' == ''">mono.llvm+</DefaultMonoSubsets>
<DefaultMonoSubsets Condition="'$(TargetOS)' == 'Browser'">$(DefaultMonoSubsets)mono.wasmruntime+</DefaultMonoSubsets>
<DefaultMonoSubsets Condition="'$(BuildMonoCrossAOT)' == 'true'">$(DefaultMonoSubsets)mono.aotcross+</DefaultMonoSubsets>
<DefaultMonoSubsets Condition="'$(BuildMonoCrossAOT)' != ''">$(DefaultMonoSubsets)mono.aotcross+</DefaultMonoSubsets>
directhex marked this conversation as resolved.
Show resolved Hide resolved
<DefaultMonoSubsets>$(DefaultMonoSubsets)mono.runtime+mono.corelib+mono.packages</DefaultMonoSubsets>

<DefaultLibrariesSubsets>libs.native+libs.ref+libs.src+libs.pretest+libs.packages</DefaultLibrariesSubsets>
Expand Down Expand Up @@ -288,7 +288,7 @@
<SharedFrameworkProjectToBuild Condition="'$(RuntimeFlavor)' != 'Mono'" Include="$(InstallerProjectRoot)pkg\sfx\installers\dotnet-hostfxr.proj" />
<SharedFrameworkProjectToBuild Condition="'$(RuntimeFlavor)' != 'Mono'" Include="$(InstallerProjectRoot)pkg\sfx\installers\dotnet-runtime-deps\*.proj" />
<SharedFrameworkProjectToBuild Condition="'$(RuntimeFlavor)' != 'Mono'" Include="$(InstallerProjectRoot)pkg\sfx\bundle\Microsoft.NETCore.App.Bundle.bundleproj" />
<SharedFrameworkProjectToBuild Condition="'$(BuildMonoCrossAOT)' == 'true'" Include="$(InstallerProjectRoot)pkg\sfx\Microsoft.NETCore.App\monocrossaot.sfxproj" />
<SharedFrameworkProjectToBuild Condition="'$(BuildMonoCrossAOT)' != ''" Include="$(InstallerProjectRoot)pkg\sfx\Microsoft.NETCore.App\monocrossaot.sfxproj" />
<ProjectToBuild Include="@(SharedFrameworkProjectToBuild)" Category="packs" />
</ItemGroup>

Expand Down
8 changes: 4 additions & 4 deletions eng/pipelines/common/global-build-job.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ parameters:
variables: []
targetRid: ''
timeoutInMinutes: ''
dependsOn: ''
dependsOn: []
pool: ''
platform: ''
condition: true
Expand Down Expand Up @@ -89,11 +89,11 @@ jobs:
- ${{ if eq(parameters.isOfficialBuild, true) }}:
- template: /eng/pipelines/common/restore-internal-tools.yml

- ${{ if eq(parameters.monoCrossAOTTargetOS, 'Android') }}:
- ${{ each monoCrossAOTTargetOS in parameters.monoCrossAOTTargetOS }}:
- task: DownloadPipelineArtifact@2
displayName: Download AOT offset files
displayName: Download ${{monoCrossAOTTargetOS}} AOT offset files
inputs:
artifact: Mono_Offsets_Android
artifact: Mono_Offsets_${{monoCrossAOTTargetOS}}
path: '$(Build.SourcesDirectory)/artifacts/obj/mono/offsetfiles'

- ${{ if in(parameters.osGroup, 'OSX', 'iOS', 'tvOS', 'Android') }}:
Expand Down
14 changes: 7 additions & 7 deletions eng/pipelines/mono/templates/build-job.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ parameters:
isOfficialBuild: false
crossBuild: false
crossrootfsDir: ''
dependsOn: ''
monoCrossAOTTargetOS: ''
dependsOn: []
monoCrossAOTTargetOS: []
dependOnEvaluatePaths: false

### Product build
Expand Down Expand Up @@ -93,9 +93,9 @@ jobs:
- ${{ if eq(parameters.runtimeVariant, 'llvmaot') }}:
- name: llvmParameter
value: /p:MonoEnableLLVM=true /p:MonoBundleLLVMOptimizer=true $(llvmCxxAbi)
- ${{ if eq(parameters.monoCrossAOTTargetOS, 'Android') }}:
- ${{ if gt(length(parameters.monoCrossAOTTargetOS),0) }}:
- name: aotCrossParameter
value: /p:BuildMonoCrossAOT=true /p:SkipMonoCrossJitConfigure=true /p:BuildMonoAOTCrossCompilerOnly=true
value: /p:BuildMonoCrossAOT=${{join('+',parameters.monoCrossAOTTargetOS)}} /p:SkipMonoCrossJitConfigure=true /p:BuildMonoAOTCrossCompilerOnly=true
- ${{ parameters.variables }}

steps:
Expand All @@ -112,11 +112,11 @@ jobs:
- script: $(Build.SourcesDirectory)\eng\common\init-tools-native.cmd -InstallDirectory $(Build.SourcesDirectory)\native-tools -Force
displayName: Install native dependencies

- ${{ if eq(parameters.monoCrossAOTTargetOS, 'Android') }}:
- ${{ each monoCrossAOTTargetOS in parameters.monoCrossAOTTargetOS }}:
- task: DownloadPipelineArtifact@2
displayName: Download AOT offset files
displayName: Download ${{monoCrossAOTTargetOS}} AOT offset files
inputs:
artifact: Mono_Offsets_Android
artifact: Mono_Offsets_${{monoCrossAOTTargetOS}}
path: '$(Build.SourcesDirectory)/artifacts/obj/mono/offsetfiles'

- ${{ if in(parameters.osGroup, 'OSX', 'iOS','tvOS') }}:
Expand Down
4 changes: 2 additions & 2 deletions eng/pipelines/mono/templates/generate-offsets.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,10 @@ jobs:

# Build
- ${{ if ne(parameters.osGroup, 'windows') }}:
- script: ./build$(scriptExt) -subset mono.aotcross -c $(buildConfig) -arch $(archType) $(osOverride) -ci $(officialBuildIdArg) /p:MonoGenerateOffsetsOnly=true
- script: ./build$(scriptExt) -subset mono.aotcross -c $(buildConfig) -arch $(archType) $(osOverride) -ci $(officialBuildIdArg) /p:MonoGenerateOffsetsOnly=$(osGroup)
directhex marked this conversation as resolved.
Show resolved Hide resolved
displayName: Generate AOT offsets
- ${{ if eq(parameters.osGroup, 'windows') }}:
- script: build$(scriptExt) -subset mono.aotcross -c $(buildConfig) -arch $(archType) $(osOverride) -ci $(officialBuildIdArg) /p:MonoGenerateOffsetsOnly=true
- script: build$(scriptExt) -subset mono.aotcross -c $(buildConfig) -arch $(archType) $(osOverride) -ci $(officialBuildIdArg) /p:MonoGenerateOffsetsOnly=$(osGroup)
displayName: Generate AOT offsets

# Upload offset files
Expand Down
18 changes: 12 additions & 6 deletions eng/pipelines/runtime-official.yml
Original file line number Diff line number Diff line change
Expand Up @@ -132,9 +132,10 @@ stages:
buildConfig: release
platforms:
- Android_x64
- Browser_wasm

#
# Build Mono release Android AOT cross-compiler
# Build Mono release AOT cross-compilers
#
- template: /eng/pipelines/common/platform-matrix.yml
parameters:
Expand All @@ -146,15 +147,20 @@ stages:
- Linux_x64
jobParameters:
buildArgs: -s mono+libs+host+packs -c $(_BuildConfig)
/p:BuildMonoCrossAOT=true /p:SkipMonoCrossJitConfigure=true /p:BuildMonoAOTCrossCompilerOnly=true
nameSuffix: AndroidAOT_Mono
runtimeVariant: crossandroid
dependsOn: mono_android_offsets
monoCrossAOTTargetOS: Android
/p:BuildMonoCrossAOT=Android+Browser /p:SkipMonoCrossJitConfigure=true /p:BuildMonoAOTCrossCompilerOnly=true
nameSuffix: CrossAOT_Mono
runtimeVariant: crossaot
dependsOn:
- mono_android_offsets
- mono_browser_offsets
monoCrossAOTTargetOS:
- Android
- Browser
isOfficialBuild: ${{ variables.isOfficialBuild }}
extraStepsTemplate: /eng/pipelines/common/upload-intermediate-artifacts-step.yml
extraStepsParameters:
name: MonoRuntimePacks

#
# Build Mono LLVM runtime packs
#
Expand Down
11 changes: 8 additions & 3 deletions eng/pipelines/runtime.yml
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ jobs:
buildConfig: release
platforms:
- Android_x64
- Browser_wasm
jobParameters:
condition: >-
or(
Expand Down Expand Up @@ -494,9 +495,13 @@ jobs:
# - windows_arm
# - windows_arm64
jobParameters:
runtimeVariant: crossandroid
dependsOn: mono_android_offsets
monoCrossAOTTargetOS: Android
runtimeVariant: crossaot
dependsOn:
- mono_android_offsets
- mono_browser_offsets
monoCrossAOTTargetOS:
- Android
- Browser
condition: >-
or(
eq(dependencies.evaluate_paths.outputs['SetPathVars_mono.containsChange'], true),
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
<Project Sdk="Microsoft.Build.Traversal">

<PropertyGroup>
<MonoAotTargets Condition="'$(MonoAotTargets)' == ''">android-x64;android-arm64;android-x86;android-arm</MonoAotTargets>
<_BuildMonoCrossAOT Condition="'$(BuildMonoCrossAOT)' != ''">+$(BuildMonoCrossAOT.ToLowerInvariant())+</_BuildMonoCrossAOT>
<MonoAotTargets Condition="$(_BuildMonoCrossAOT.contains('+android+'))">$(MonoAotTargets);android-x64;android-arm64;android-x86;android-arm</MonoAotTargets>
<MonoAotTargets Condition="$(_BuildMonoCrossAOT.contains('+wasm+'))">$(MonoAotTargets);browser-wasm</MonoAotTargets>
</PropertyGroup>

<ItemGroup>
Expand Down
14 changes: 7 additions & 7 deletions src/mono/mono.proj
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
<Error Condition="'$(TargetsiOS)' == 'true' and '$(Platform)' != 'x64' and '$(Platform)' != 'x86' and '$(Platform)' != 'arm64' and '$(Platform)' != 'arm'" Text="Error: Invalid platform for $(TargetOS): $(Platform)." />
<Error Condition="('$(TargetsiOS)' == 'true' or '$(TargetstvOS)' == 'true') and !$([MSBuild]::IsOSPlatform('OSX'))" Text="Error: $(TargetOS) can only be built on macOS." />
<Error Condition="'$(TargetsAndroid)' == 'true' and '$(Platform)' != 'x64' and '$(Platform)' != 'x86' and '$(Platform)' != 'arm64' and '$(Platform)' != 'arm'" Text="Error: Invalid platform for $(TargetOS): $(Platform)." />
<Error Condition="'$(TargetsBrowser)' == 'true' and '$(EMSDK_PATH)' == ''" Text="The EMSDK_PATH environment variable should be set pointing to the emscripten SDK root dir."/>
<Error Condition="'$(TargetsBrowser)' == 'true' and '$(EMSDK_PATH)' == '' and '$(SkipMonoCrossJitConfigure)' != 'true'" Text="The EMSDK_PATH environment variable should be set pointing to the emscripten SDK root dir."/>
<Error Condition="'$(TargetsAndroid)' == 'true' and '$(ANDROID_NDK_ROOT)' == '' and '$(SkipMonoCrossJitConfigure)' != 'true'" Text="Error: You need to set the ANDROID_NDK_ROOT environment variable pointing to the Android NDK root." />
<Error Condition="'$(OS)' == 'Windows_NT' and ('$(TargetsiOS)' == 'true' or '$(TargetstvOS)' == 'true')" Text="Error: Mono runtime for $(TargetOS) can't be built on Windows." />

Expand Down Expand Up @@ -472,10 +472,10 @@
<Exec Condition="'$(MonoUseCrossTool)' == 'true' and !Exists('$(MonoAotOffsetsFile)')" Command="$(_MonoAotCrossOffsetsCommand)" IgnoreStandardErrorWarningFormat="true" />
<!-- configure -->
<Message Text="Running '$(_MonoAotCMakeConfigureCommand)' in '$(MonoObjDir)/cross'" Importance="High" />
<Exec Condition="'$(MonoGenerateOffsetsOnly)' != 'true'" Command="$(_MonoAotCMakeConfigureCommand)" IgnoreStandardErrorWarningFormat="true" WorkingDirectory="$(MonoObjDir)/cross"/>
<Exec Condition="'$(MonoGenerateOffsetsOnly)' == ''" Command="$(_MonoAotCMakeConfigureCommand)" IgnoreStandardErrorWarningFormat="true" WorkingDirectory="$(MonoObjDir)/cross"/>
<!-- build -->
<Message Text="Running '$(_MonoAotCMakeBuildCommand)' in '$(MonoObjDir)/cross'" Importance="High" />
<Exec Condition="'$(MonoGenerateOffsetsOnly)' != 'true'" Command="$(_MonoAotCMakeBuildCommand)" IgnoreStandardErrorWarningFormat="true" WorkingDirectory="$(MonoObjDir)/cross"/>
<Exec Condition="'$(MonoGenerateOffsetsOnly)' == ''" Command="$(_MonoAotCMakeBuildCommand)" IgnoreStandardErrorWarningFormat="true" WorkingDirectory="$(MonoObjDir)/cross"/>
</Target>

<Target Name="InitializeGenerateRuntimeVersionFile"
Expand Down Expand Up @@ -543,22 +543,22 @@
<_MonoRuntimeArtifacts Condition="'$(_MonoIncludeInterpStaticFiles)' == 'true'" Include="$(MonoObjDir)out\lib\libmono-ilgen.a">
<Destination>$(RuntimeBinDir)libmono-ilgen.a</Destination>
</_MonoRuntimeArtifacts>
<_MonoRuntimeArtifacts Condition="'$(TargetsBrowser)' == 'true'" Include="$(MonoObjDir)out\lib\libmono-profiler-aot.a">
<_MonoRuntimeArtifacts Condition="'$(TargetsBrowser)' == 'true' and '$(BuildMonoAOTCrossCompilerOnly)' != 'true'" Include="$(MonoObjDir)out\lib\libmono-profiler-aot.a">
<Destination>$(RuntimeBinDir)libmono-profiler-aot.a</Destination>
</_MonoRuntimeArtifacts>
</ItemGroup>

<Copy SourceFiles="@(_MonoRuntimeArtifacts)"
DestinationFiles="%(_MonoRuntimeArtifacts.Destination)"
Condition="'$(MonoGenerateOffsetsOnly)' != 'true'"
Condition="'$(MonoGenerateOffsetsOnly)' == ''"
SkipUnchangedFiles="true" />

<Copy SourceFiles="@(_MonoIncludeArtifacts)"
DestinationFiles="@(_MonoIncludeArtifacts->'$(RuntimeBinDir)include\%(RecursiveDir)%(Filename)%(Extension)')"
SkipUnchangedFiles="true"
Condition="'$(MonoGenerateOffsetsOnly)' != 'true' and ('$(TargetsiOS)' == 'true' or '$(TargetstvOS)' == 'true' or '$(TargetsAndroid)' == 'true' or '$(TargetsBrowser)' == 'true')"/>
Condition="'$(MonoGenerateOffsetsOnly)' == '' and ('$(TargetsiOS)' == 'true' or '$(TargetstvOS)' == 'true' or '$(TargetsAndroid)' == 'true' or '$(TargetsBrowser)' == 'true')"/>

<Exec Condition="'$(BuildMonoAOTCrossCompilerOnly)' != 'true' and '$(MonoGenerateOffsetsOnly)' != 'true' and ('$(TargetsOSX)' == 'true' or '$(TargetsiOS)' == 'true' or '$(TargetstvOS)' == 'true')" Command="install_name_tool -id @rpath/$(MonoFileName) $(RuntimeBinDir)$(MonoFileName)" />
<Exec Condition="'$(BuildMonoAOTCrossCompilerOnly)' != 'true' and '$(MonoGenerateOffsetsOnly)' == '' and ('$(TargetsOSX)' == 'true' or '$(TargetsiOS)' == 'true' or '$(TargetstvOS)' == 'true')" Command="install_name_tool -id @rpath/$(MonoFileName) $(RuntimeBinDir)$(MonoFileName)" />
</Target>

<Target Name="CleanMono">
Expand Down
7 changes: 6 additions & 1 deletion src/mono/monoaotcross.proj
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,12 @@

<PropertyGroup>
<!-- OS name is case sensitive! -->
<MonoAotTargets Condition="'$(MonoAotTargets)' == ''">Android-x64;Android-arm64;Android-x86;Android-arm</MonoAotTargets>
<_BuildMonoCrossAOT Condition="'$(BuildMonoCrossAOT)' != ''">+$(BuildMonoCrossAOT.ToLowerInvariant())+</_BuildMonoCrossAOT>
<_MonoGenerateOffsetsOnly Condition="'$(MonoGenerateOffsetsOnly)' != ''">+$(MonoGenerateOffsetsOnly.ToLowerInvariant())+</_MonoGenerateOffsetsOnly>
<_BuildMonoCrossAOT Condition="$(_MonoGenerateOffsetsOnly.contains('+android+'))">$(_BuildMonoCrossAOT)+android+</_BuildMonoCrossAOT>
<_BuildMonoCrossAOT Condition="$(_MonoGenerateOffsetsOnly.contains('+browser+'))">$(_BuildMonoCrossAOT)+browser+</_BuildMonoCrossAOT>
<MonoAotTargets Condition="$(_BuildMonoCrossAOT.contains('+android+'))">$(MonoAotTargets);Android-x64;Android-arm64;Android-x86;Android-arm</MonoAotTargets>
<MonoAotTargets Condition="$(_BuildMonoCrossAOT.contains('+browser+'))">$(MonoAotTargets);Browser-wasm</MonoAotTargets>
</PropertyGroup>

<ItemGroup>
Expand Down