[IGNORE][wasm] Testing AOT tests on helix #50827
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since AOT'ing each test suite takes between 3-9 min, we need to shift the burden over to helix.
…nto build-wasm-aot-helix
…m run with EnableAggressiveTrimming enabled
…m run with EnableAggressiveTrimming enabled
.. simply by adding `/p:BuildWasmAOTTestsOnHelix=true` to the build command line.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
radical
added
the
NO-MERGE
.. to the proxy project on helix. This also fixes dotnet#50727 , by correctly passing `$(InvariantGlobalization)` property to the proxy project. So, re-enable `Invariant.Tests`.
radical
force-pushed
the
build-wasm-aot-helix-test-aj
branch
from
df56e77
to
6e63861
Compare
…or non-wasm cases too
|
Changes merged into the original PR - #48226 . Closing this. |
This was referenced Apr 7, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.