Make mono runtime tests stop using patching in CI; remove dependency on coreclr #62652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lambdageek
reviewed
Dec 10, 2021
@naricc seems like it's working! 🎉 |
naricc
changed the title
jkoritzinsky
approved these changes
Dec 13, 2021
safern
approved these changes
Dec 13, 2021
|
Failures in |
|
@safern Do we already have a seperate issue for that (collapsing to global-build template)? If not I will create one. |
This was referenced Dec 14, 2021
lambdageek
added a commit
to lambdageek/runtime
that referenced
this pull request
Dec 14, 2021
Shouldn't be needed after dotnet#62652 Contributes to dotnet#51584, I think
lambdageek
pushed a commit
that referenced
this pull request
Dec 15, 2021
This partially reverts this change: #62652 The problem is that although we no longer need to patch, we do need corerun from the clr.hosts subset. Corerun still ends up as part of the pubished clr product artifact, and not in the mono product artifact. And thus we still end up downloading clr, and still need this dependency for now.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the patching step for mono in CI, and removes the dependency on coreclr, for desktop configurations.
Contributes to #58266
Fixes #43952