Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Don't download CoreCLR product for Mono runtime tests #62785

Conversation

lambdageek
Copy link
Member

Shouldn't be needed after #62652

Contributes to #51584, I think

@ghost
Copy link

ghost commented Dec 14, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Shouldn't be needed after #62652

Contributes to #51584, I think

Author: lambdageek
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: -

@lambdageek
Copy link
Member Author

lambdageek commented Dec 14, 2021

@akoeplinger @safern How are these artifacts actually used?

Are there other pipeline steps that consume CoreCLR artifacts during Mono runs?

@lambdageek
Copy link
Member Author

lambdageek commented Dec 14, 2021

Hmm... what target creates MonoProduct___OSX_x64_release.tar.gz - I think I need to update it to put corerun in that tgz

I guess it's this step:

# Publish product output directory for consumption by tests.
- template: /eng/pipelines/common/upload-artifact-step.yml
parameters:
rootFolder: $(buildProductRootFolderPath)
includeRootFolder: false
archiveType: $(archiveType)
tarCompression: $(tarCompression)
archiveExtension: $(archiveExtension)
artifactName: $(buildProductArtifactName)
displayName: 'product build'

And it's zipping up this directory:

- name: buildProductRootFolderPath
value: '$(Build.SourcesDirectory)/artifacts/bin/mono/$(osGroup).$(archType).$(buildConfigUpper)'

@lambdageek
Copy link
Member Author

Seems pretty clear this won't work. We will return to it once we have a strategy.

At the moment, though, we don't think the Mono runs are using CoreCLR: the https://github.com/dotnet/runtime/blob/main/src/tests/baseservices/mono/runningmono.cs test is passing, and the Core_Root generation is still taking the runtime flavor into account

# Compose the Core_Root folder containing all artifacts needed for running
# CoreCLR tests. This step also compiles the framework using Crossgen / Crossgen2
# in ReadyToRun jobs.
- script: $(Build.SourcesDirectory)/src/tests/build$(scriptExt) generatelayoutonly $(logRootNameArg)Layout $(runtimeFlavorArgs) $(crossgenArg) $(buildConfig) $(archType) $(crossArg) $(priorityArg) $(librariesOverrideArg)
displayName: Generate CORE_ROOT

So we're just downloading a bigger tarball than we otherwise would. We're not configuring the test runs incorrectly.

@lambdageek lambdageek closed this Dec 14, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jan 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant