Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MonoAOTCompilerTask: Don't check for temp file if cache is disabled #71411

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

radical
Copy link
Member

@radical radical commented Jun 28, 2022

Prompted by #70851 (comment)

@radical
Copy link
Member Author

radical commented Jun 28, 2022

/azp run runtime-extra-platforms,runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@radical
Copy link
Member Author

radical commented Jun 29, 2022

Failures are unrelated.

@radical radical merged commit c755dcc into dotnet:main Jun 29, 2022
@radical radical deleted the fix-aot-tmp branch June 29, 2022 18:44
jonathanpeppers added a commit to dotnet/android that referenced this pull request Jul 1, 2022
Changes: dotnet/installer@970be08...cf6da7b
Changes: dotnet/linker@618eb72...5460697
Changes: dotnet/runtime@5c5e66e...ddc4f95
Changes: dotnet/emsdk@ea10b4e...3fbbd97

Updates:

* Microsoft.Dotnet.Sdk.Internal: from 7.0.100-preview.6.22316.8 to 7.0.100-preview.7.22327.1
* Microsoft.NET.ILLink.Tasks: from 7.0.100-1.22310.2 to 7.0.100-1.22323.2
* Microsoft.NETCore.App.Ref: from 7.0.0-preview.6.22312.1 to 7.0.0-preview.6.22322.7
* Microsoft.NET.Workload.Emscripten.Manifest-7.0.100: from 7.0.0-preview.6.22281.1 to 7.0.0-preview.6.22320.1

* Update `.apkdesc` files for Xamarin.Forms sample

There appears to be a new System.Xml.Linq facade with:

    [assembly: TypeForwardedTo(typeof(XAttribute))]
    [assembly: TypeForwardedTo(typeof(XElement))]

* Temporarily ignore `BuildBasicApplicationReleaseProfiledAot(true)`

Should eventually be fixed by:

dotnet/runtime#71411

Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com>
jonathanpeppers added a commit to dotnet/android that referenced this pull request Jul 1, 2022
Changes: dotnet/installer@970be08...53fae57
Changes: dotnet/linker@618eb72...5128bae
Changes: dotnet/runtime@5c5e66e...d3fa592
Changes: dotnet/emsdk@ea10b4e...3fbbd97

Updates:

* Microsoft.Dotnet.Sdk.Internal: from 7.0.100-preview.6.22316.8 to 7.0.100-preview.6.22330.5
* Microsoft.NET.ILLink.Tasks: from 7.0.100-1.22310.2 to 7.0.100-1.22323.1
* Microsoft.NETCore.App.Ref: from 7.0.0-preview.6.22312.1 to 7.0.0-preview.6.22324.4
* Microsoft.NET.Workload.Emscripten.Manifest-7.0.100: from 7.0.0-preview.6.22281.1 to 7.0.0-preview.6.22320.1

* Update `.apkdesc` files for Xamarin.Forms sample

There appears to be a new System.Xml.Linq facade with:

    [assembly: TypeForwardedTo(typeof(XAttribute))]
    [assembly: TypeForwardedTo(typeof(XElement))]

* Temporarily ignore `BuildBasicApplicationReleaseProfiledAot(true)`

Should eventually be fixed by:

dotnet/runtime#71411

Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com>
@ghost ghost locked as resolved and limited conversation to collaborators Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants