Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MonoAOTCompilerTask: Don't check for temp file if cache is disabled #71411

Merged
merged 2 commits into from
Jun 29, 2022
Merged

MonoAOTCompilerTask: Don't check for temp file if cache is disabled #71411

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eed4923
MonoAOTCompilerTask: Don't check for temp file if cache is disabled
radical Jun 28, 2022
7f44b00
Emit a message when deleting tmp files
radical Jun 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions src/tasks/AotCompilerTask/MonoAOTCompiler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -936,12 +936,6 @@ private bool PrecompileLibrary(PrecompileArguments args)
bool copied = false;
foreach (var proxyFile in args.ProxyFiles)
{
if (!File.Exists(proxyFile.TempFile))
{
Log.LogError($"Precompile command succeeded, but can't find the expected temporary output file - {proxyFile.TempFile} for {assembly}.{Environment.NewLine}{output}");
return false;
}

copied |= proxyFile.CopyOutputFileIfChanged();
_fileWrites.Add(proxyFile.TargetFile);
}
Expand Down Expand Up @@ -1225,11 +1219,11 @@ public bool CopyOutputFileIfChanged()
if (!_cache.Enabled)
return true;

if (!File.Exists(TempFile))
throw new LogAsErrorException($"Could not find the temporary file {TempFile} for target file {TargetFile}. Look for any errors/warnings generated earlier in the build.");

try
{
if (!File.Exists(TempFile))
throw new LogAsErrorException($"Could not find the temporary file {TempFile} for target file {TargetFile}. Look for any errors/warnings generated earlier in the build.");

if (!_cache.ShouldCopy(this, out string? cause))
{
_cache.Log.LogMessage(MessageImportance.Low, $"Skipping copying over {TargetFile} as the contents are unchanged");
Expand All @@ -1246,6 +1240,7 @@ public bool CopyOutputFileIfChanged()
}
finally
{
_cache.Log.LogMessage(MessageImportance.Low, $"Deleting temp file {TempFile}");
File.Delete(TempFile);
}
}
Expand Down