Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable tests for #66421 #73052

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Re-enable tests for #66421 #73052

merged 1 commit into from
Jul 29, 2022

Conversation

krwq
Copy link
Member

@krwq krwq commented Jul 29, 2022

Fixes #66421

Seems I have already fixed this bug accidentally when doing contract customization work in #70435

Specifically these:
897b2a3#diff-b7da6b90947be2bdebc35f367d9dc2c5bb66dd3be881af8a2d6cbb9c18108a7fL529-L530

plus adjustments in JsonMetadataServices

@ghost
Copy link

ghost commented Jul 29, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #66421

Seems I have already fixed this bug accidentally when doing contract customization work in #70435

Specifically these:
897b2a3#diff-b7da6b90947be2bdebc35f367d9dc2c5bb66dd3be881af8a2d6cbb9c18108a7fL529-L530

  • adjustments in JsonMetadataServices
Author: krwq
Assignees: -
Labels:

area-System.Text.Json

Milestone: -

@krwq krwq merged commit 20b42d5 into dotnet:main Jul 29, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON source generator fails with recursive collection type graphs
2 participants